forward declarations

Bug #592215 reported by Miika Komu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HIPL
Fix Released
Undecided
Artturi Karila

Bug Description

DB: Forward declarations should hardly ever be necessary, but they are found
all over HIPL.

Miika Komu (miika-iki)
Changed in hipl:
assignee: nobody → Artturi Karila (artturi-karila)
Changed in hipl:
status: New → Fix Committed
Revision history for this message
René Hummen (rene-hummen) wrote :

Are _all_ forward declarations removed by now?

Is there an easy way to grep for forward declarations?

Revision history for this message
Diego Biurrun (diego-biurrun) wrote :

The following found one more:

~/src/hipl/trunk $ find . -name \*.c | xargs grep -P -r '^[a-zA-Z0-9]+ .+[a-zA-Z0-9_]+\(.*\);'
./firewall/hslist.c:static SList *slist_last(SList *list);

My idea was to grep for keyword/type at the beginning of the line, then a space, then the function name, some stuff within parentheses and the semicolon. Probably I'm overlooking something, but that should have discovered the most glaring cases.

Changed in hipl:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.