Upgrade should not warn that the repository needs an upgrade

[Aaron Bentley]

$ bzr upgrade
Format <RepositoryFormat6> for file:///mnt/www/new.panometrics.com/.bzr/ is deprecated - please use 'bzr upgrade' to get better performance
starting upgrade of file:///mnt/www/new.panometrics.com/
making backup of tree history
[etc.]

(The warning is harmless, but confusing - it reflects that the branch is being opened to upgrade.)

[John A Meinel (jameinel)]

Well, for the new WorkingTree3 => 4 changes, it doesn't:

bzr init --format knit wt3
cd wt3
bzr st

Working tree format 3 is deprecated and a better format is available.
It is recommended that you upgrade by running the command
  bzr upgrade file:///Users/jameinel/dev/%2Ctmp/wt3/

bzr upgrade
starting upgrade of file:///Users/jameinel/dev/%2Ctmp/wt3/
making backup of tree history
file:///Users/jameinel/dev/%2Ctmp/wt3/.bzr has been backed up to file:///Users/jameinel/dev/%2Ctmp/wt3/.bzr.backup
if conversion fails, you can move this directory back to .bzr
if it succeeds, you can remove this directory if you wish
finished

So that works as we want it to. However, the old Weave format repository still complains:

bzr init --format weave test

Format <RepositoryFormat6> for file:///Users/jameinel/dev/%2Ctmp/test/.bzr/ is deprecated - please use 'bzr upgrade' to get better performance

cd test
# bzr status also complains
bzr upgrade

Format <RepositoryFormat6> for file:///Users/jameinel/dev/%2Ctmp/test/.bzr/ is deprecated - please use 'bzr upgrade' to get better performance
starting upgrade of file:///Users/jameinel/dev/%2Ctmp/test/
making backup of tree history
file:///Users/jameinel/dev/%2Ctmp/test/.bzr has been backed up to file:///Users/jameinel/dev/%2Ctmp/test/.bzr.backup
if conversion fails, you can move this directory back to .bzr
if it succeeds, you can remove this directory if you wish
starting upgrade from format 6 to metadir
starting repository conversion
repository converted
finished

I would consider closing this bug, since newer formats don't complain in the same way. But older formats do, so for now, I'm marking it Confirmed.

[Martin Pool (mbp)]

And in fact now new formats do.

In general the warning should be given in a way that upgrade can silence it.