person.inTeam(other_person) hits the db (when both not teams)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Unassigned |
Bug Description
Here is a snippet of my large debugging output. Here I know that user and self.obj.person are both individuals, so there should be no team participation check.
File "/home/
return (user.inTeam(
File "/home/
tp = TeamParticipati
<snippity>
SELECT TeamParticipati
We could special case this to avoid db queries.
Related branches
- Robert Collins (community): Approve
-
Diff: 344 lines (+85/-83)4 files modifiedlib/lp/registry/doc/person.txt (+0/-25)
lib/lp/registry/doc/teammembership.txt (+23/-50)
lib/lp/registry/model/person.py (+20/-6)
lib/lp/registry/tests/test_person.py (+42/-2)
Changed in launchpad-registry: | |
milestone: | series-future → 10.10 |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
Changed in launchpad-registry: | |
status: | In Progress → Fix Committed |
tags: | added: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad-registry: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
I recall inTeam() also special cases the owner. We should make this method sensible.