[Mac] Phatch cannot open saved task file

[SeySayux]

Description: Phatch on Mac cannot open a saved task file using the Finder.

Steps to reproduce:
* Open Phatch on Mac
* Make a small task list
* Save
* Close Phatch
* Open saved file through the Finder

You will notice:
Error message:
----
Phatch Error
An unexpected error has occurred during execution of the main script

TypeError: 'NoneType' object is not callable
----

There is a button labeled "Show Console". When I click that, I get:
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112] Traceback
(most recent call last):
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
 File "/Applications/Phatch.app/Contents/Resources/app.py", line 35,
in <module>
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
  from core.context import CONTEXT, check_user_paths
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
 File "core/context.pyc", line 38, in <module>
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
 File "lib/context.pyc", line 144, in get_context
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
 File "lib/context.pyc", line 110, in _find_source_path
7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
 File "lib/context.pyc", line 97, in _find_parent

Untested:
Opening the saved file through Phatch's "Open" dialog.

[SeySayux (seysayux)]

Example file used to demonstrate the bug.

[Stani (stani)]

$ bzr diff
=== modified file 'phatch/lib/recentFiles.py'
--- phatch/lib/recentFiles.py 2010-03-29 15:17:43 +0000
+++ phatch/lib/recentFiles.py 2010-06-08 12:38:21 +0000
@@ -57,7 +57,7 @@

     # mac
     else:
- add = None
+ return ignore

     return add

$ bzr commit
Committing to: /home/stani/sync/python/phatch/repo/trunk/
modified phatch/lib/recentFiles.py

Ran 159 license tests in 1.627s
----------------------------------------------------------------------
Ran 57 tests in 0.481s

OK
----------------------------------------------------------------------
Ran 159 PEP8 tests in 0.252s

Ran precommit tests in 7.717s

Committed revision 1941.

[robinmills (robinmills)]

Ah! Well done.

Robin

On Jun 8, 2010, at 6:40 AM, Stani wrote:

> $ bzr diff
> === modified file 'phatch/lib/recentFiles.py'
> --- phatch/lib/recentFiles.py 2010-03-29 15:17:43 +0000
> +++ phatch/lib/recentFiles.py 2010-06-08 12:38:21 +0000
> @@ -57,7 +57,7 @@
>
> # mac
> else:
> - add = None
> + return ignore
>
> return add
>
> $ bzr commit
> Committing to: /home/stani/sync/python/phatch/repo/trunk/
> modified phatch/lib/recentFiles.py
>
> Ran 159 license tests in 1.627s
> ----------------------------------------------------------------------
> Ran 57 tests in 0.481s
>
> OK
> ----------------------------------------------------------------------
> Ran 159 PEP8 tests in 0.252s
>
> Ran precommit tests in 7.717s
>
> Committed revision 1941.
>
> ** Changed in: phatch
> Importance: Undecided => Medium
>
> ** Changed in: phatch
> Status: New => Fix Released
>
> ** Changed in: phatch
> Milestone: None => 0.2.8
>
> ** Changed in: phatch
> Assignee: (unassigned) => Stani (stani)
>
> ** Summary changed:
>
> - Phatch cannot open saved task file on Mac
> + [Mac] Phatch cannot open saved task file
>
> --
> [Mac] Phatch cannot open saved task file
> https://bugs.launchpad.net/bugs/591246
> You received this bug notification because you are a member of Phatch
> Launchpad Team, which is subscribed to Phatch.
>
> Status in Phatch = Photo & Batch!: Fix Released
>
> Bug description:
> Description: Phatch on Mac cannot open a saved task file using the Finder.
>
> Steps to reproduce:
> * Open Phatch on Mac
> * Make a small task list
> * Save
> * Close Phatch
> * Open saved file through the Finder
>
> You will notice:
> Error message:
> ----
> Phatch Error
> An unexpected error has occurred during execution of the main script
>
> TypeError: 'NoneType' object is not callable
> ----
>
> There is a button labeled "Show Console". When I click that, I get:
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112] Traceback
> (most recent call last):
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> File "/Applications/Phatch.app/Contents/Resources/app.py", line 35,
> in <module>
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> from core.context import CONTEXT, check_user_paths
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> File "core/context.pyc", line 38, in <module>
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> File "lib/context.pyc", line 144, in get_context
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> File "lib/context.pyc", line 110, in _find_source_path
> 7/06/10 16:04:11 [0x0-0x23023].org.pythonmac.unspecified.Phatch[1112]
> File "lib/context.pyc", line 97, in _find_parent
>
> Untested:
> Opening the saved file through Phatch's "Open" dialog.
>
>

Robin
http://clanmills.com

[kompilesoft (kestrel-andre)]

I got the same error with test.phatch