agent RPM

[Remi Debay]

L'agent n'est pas disponible sous le format RPM. Ce format est nécessaire pour installer l'agent sur fedora, CENTOS, VMWare esx....

[Rémi (rmi-redhat-bugs)]

Spec URL: http://launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent.spec
SRPM URL: http://launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent-5.1.6-1.fc15.src.rpm
Description:

Hi all,

I just finished packaged acgvision-agent. Could anyone review my package so that I could get it onto Fedora repositories?

ACGVision is a monitoring sofware (like nagios) and this is the client software.

It's my really first fedora package (and RPM)so please tell me about anything s going wrong with my package.

Thanks

Rémi Debay

[Remi Debay (debay-remi-gmail)]

La première demande a été effectuée auprès de Fedora.

[Remi Debay (debay-remi-gmail)]

https://bugzilla.redhat.com/show_bug.cgi?id=622820

[Alexander (alexander-redhat-bugs)]

I'll take this one.

[Alexander (alexander-redhat-bugs)]

Let me know when you get the javadoc subpackage fixed and I'll do the review.

[Rémi (rmi-redhat-bugs)]

Hi

I uploaded the new spec file with the javadoc.

You can download it there :
http://launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent.2.spec

Thanks for your help

Rémi

[Alexander (alexander-redhat-bugs)]

Please upload the new srpm too. So I can be sure I'm reviewing exactly what you have.

[Rémi (rmi-redhat-bugs)]

Oh sorry i forgot to upload this

Here is it :

http://edge.launchpad.net/acgvision-agent/5.1.6/5.1.6-fedora/+download/acgvision-agent-5.1.6-2.fc15.src.rpm

[Alexander (alexander-redhat-bugs)]

Sorry for the delay I missed your last comment.
Do you still want me to do the review?

[Rémi (rmi-redhat-bugs)]

No worries, Yes I d be happy if u could review my package.

[Alexander (alexander-redhat-bugs)]

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[!] Rpmlint output:
 acgvision-agent-javadoc.noarch: W: non-standard-group Development Documentation
Use Documentation only
./SPECS/acgvision-agent.spec: W: no-cleaning-of-buildroot %install
Not a problem in recent Fedora.
./SPECS/acgvision-agent.spec:54: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1)
Please use either tabs or spaces.
[x] Package is named according to the Package Naming Guidelines[1].
[x] Spec file name must match the base package name, in the format %{name}.spec.
[!] Package meets the Packaging Guidelines.
You miss the following requires
Requires(post): chkconfig
Requires(preun): chkconfig
# This is for /sbin/service
Requires(preun): initscripts

[x] Package successfully compiles and builds into binary rpms.
[x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
[x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[!] License field in the package spec file matches the actual license.
License type:GPLv2 in spec but GPLv3 in the copying.txt and license files shipped with sources
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x] All independent sub-packages have license of their own
[x] Spec file is legible and written in American English.
[x] Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package :f91be30d4fb8fad9d5e15f8e51b28482
MD5SUM upstream package:f91be30d4fb8fad9d5e15f8e51b28482
[x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x] Package must own all directories that it creates.
[x] Package requires other packages for directories it uses.
[x] Package does not contain duplicates in %files.
[x] Permissions on files are set properly.
[x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
[x] Package consistently uses macros.
[x] Package contains code, or permissable content.
[x] Fully versioned dependency in subpackages, if present.
[-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x] Package does not own files or directories owned by other packages.
[x] Javadoc documentation files are generated and included in -javadoc subpackage
[x] Packages have proper BuildRequires/Requires on jpackage-utils
[x] Javadoc subpackages have Require: jpackage-utils
[x] Package uses %global not %define
[-] If package uses tarball from VCS include comment how to re-create that trball (svn export URL, git clone URL, ...)
[x] If source tarball includes bundled jar/class files these need to be removed prior to building
[x ] All filenames in rpm packages must be valid UTF-8.

=== Other suggestions ===
[x] If possible use upstream build method (maven/ant/javac)
[x] Javadocs are placed in %{_ja...

[Alexander (alexander-redhat-bugs)]

Still interested?
If not I'll close the bug shortly.

[Alexander (alexander-redhat-bugs)]

I'm closing the bug. Please reopen once you have time for it again.