[patch] Exaile needs to handle vorbis embedded cover art better

Bug #590363 reported by Christian Kampka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Medium
Christian Kampka
Nominated for 0.3.2 by Christian Kampka
Nominated for 0.3.x by Christian Kampka

Bug Description

Exaile needs to improve vorbis embedded covers in several ways:

First, the recommended tag is METADATA_BLOCK_PICTURE which is currently not supported. The COVERART tag is considered deprecated. See http://wiki.xiph.org/index.php/VorbisComment#METADATA_BLOCK_PICTURE for details.
Second, the TagCoverFetcher should not break the check loop if it encounters an empty tag, but continue looping until it finds a tag that actually contains some data.

Tags: patch

Related branches

Revision history for this message
Christian Kampka (kampka) wrote :

I have extended my previous patch so that exaile can now handle special FLAC covers as well.

Revision history for this message
Christian Kampka (kampka) wrote :

I have reworked my patch again, it contains a cleaner solution now.

Revision history for this message
reacocard (reacocard) wrote :

Can we rework the FlacCoverFetcher to just return those blocks as tags in xl/metadata/*, and then adjust TagCoverFetcher to pick up on them? I think that would be a cleaner solution, with the this one we run the risk of parsing the file twice if covers are not found - once in FlacCoverFetcher and once in TagCoverFetcher. metadata_block_picture at least should be trivial to move, and i can't imagine the flac-specific one will be hard either.

Changed in exaile:
assignee: nobody → Christian Kampka (kampka)
importance: Undecided → Medium
milestone: none → 0.3.2
status: New → In Progress
Revision history for this message
Christian Kampka (kampka) wrote :

Adjusted patch according to reaocards comments on IRC.

Revision history for this message
reacocard (reacocard) wrote :

committed r3382, thanks!

Changed in exaile:
status: In Progress → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.