sendingProfile == NO during "Check for updates automatically?" window

Bug #590314 reported by Terin Stock
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Sparkle
Fix Committed
Low
Unassigned

Bug Description

It seems that when the "Check for updates automatically?" window is launched, on second launch, it populates the "this information will be sent" with sendingProfile being false.

In my code, I create a mutable array, then only add to that array if sendingProfile is true.

Since when that window appears, the code is being called with sendingProfile being false (which is, technically true, as the user hasn't given permission to send the data), my additions are not displayed in the window.

Removing or inverting the if statement shows the info as expected, but it is (at least in my understanding) incorrect.

Revision history for this message
Andy Matuschak (andymatuschak) wrote :

Thanks for reporting this one. It was fixed a while back: http://github.com/andymatuschak/Sparkle/commit/827c6adc0349b98b81b6e1e294ca53c84ca9ee52

Still hasn't been a release since then, since I am bad at this. Sorry. :) Feel free to use HEAD, though; I keep it stable.

Changed in sparkle:
status: New → Fix Committed
importance: Undecided → Low
milestone: none → 1.5
Revision history for this message
Terin Stock (terinjokes) wrote :

Nothing like reporting a bug nearly a year after the fix was committed. You must be making Windows Vista. ;)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.