Impossible to cancel the Average Path Length Statistic calculation

[Paul-Antoine Bittner]

- Open a graph with a large number of nodes (Power Grid.gml for instance)
- Run the average path length statistic (undirected)
- While the operation is running, clicking on "cancel" has no effect (The only way to cancel the calculation is with the cross button next to the progress bar)

[Paul-Antoine Bittner (pbittner-deactivatedaccount)]

The bug arises when more than one StatisticsUI is associated to one Statistic. It comes from the fact that all StatisticsFrontEnd are refreshed each time one StatiscticsUI is set running (line 103 of StatisticsControllerImpl). This refreshing process has for effect to set the currentStatistic variable to null of the StatisticsFrontEnd associated with the "Average Path Length" Statistic. And because of that, it is impossible to cancel the Statistic.

The fix provided makes sure all StatisticsUI are added to the runningList before firing the ChangeEvent that refresh all StatisticsFrontEnd. By doing so it is now possible to cancel the "Average Path Length" Statistic by clicking on "Cancel" next to the name of the Statistic. However, it is not possible to do so by clicking on "Cancel" next to the "Network Diameter" Statistic. To make that possible, one way would be to add a getStatistic method in the StatisticsUI class so that each StatisticsFrontEnd could update its currentStatistic variable with the instance of Statistic contained in its statisticsUI variable.

[Mathieu Bastian (mathieu.bastian)]

Hi thanks for your help!

There is no other way than changing StatisticsUI to fix it? I would prefer not to change the API.

[Paul-Antoine Bittner (pbittner-deactivatedaccount)]

I hadn't realized that there was an easier way.

I pushed a fix that completely solves the issue.