bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local fails with bzr-git installed

[Gary van der Merwe]

If you have bzr-git installed, and you run

bzr selftest bzrlib.tests.test_import_tariff.TestImportTariffs.test_simple_local

You get a test failure:

AssertionError: command ['st'] loaded forbidden modules ['bzrlib.foreign']

[Jelmer Vernooij (jelmer)]

bzr-git needs to be able to register entries in foreign_vcs_registry. Either bzrlib.foreign should be allowed or that registry should be moved.

[Gary van der Merwe (garyvdm)]

How come bzr-git causes the failure, but bzr-svn does not?

[Jelmer Vernooij (jelmer)]

On Fri, 2010-06-04 at 14:19 +0000, Gary van der Merwe wrote:
> How come bzr-git causes the failure, but bzr-svn does not?
No idea, bzr-svn has the exact same import (line 67).

Cheers,

Jelmer

[Martin Pool (mbp)]

On 5 June 2010 00:08, Jelmer Vernooij <email address hidden> wrote:
> bzr-git needs to be able to register entries in foreign_vcs_registry.
> Either bzrlib.foreign should be allowed or that registry should be
> moved.

I agree with that. It would be ok to just remove it to support plugins.

Along the lines we recently discussed for hooks, perhaps we should
look at moving the registries that plugins need to connect to into a
smaller number of files so that the actually subsystem they register
into need not be loaded for the plugin to load.

--
Martin