Attempting to backup / seems to result in nonsensical rsync command line

[Mike.lifeguard]

Here's the log entry, showing a nonsensical rsync command line:

Jun 2 14:31:06 localhost backintime (root): INFO: Command "rsync -aEAX -v --delete-excluded --chmod=Fa-w,D+w --whole-file --delete --exclude="/var/backups" --exclude="/root/.local/share/backintime" --include="//" --exclude=".*" --exclude="*.backup*" --exclude="*~" --exclude="/home/mikelifeguard/backups" --exclude="/home/mikelifeguard/Downloads" --exclude="/home/mikelifeguard/Music" --exclude="/home/mikelifeguard/Pictures" --exclude="/home/mikelifeguard/Videos" --exclude="/var/backups" --exclude="/dev" --exclude="/cdrom" --exclude="/proc" --exclude="/tmp" --include="//**" --exclude="*" / "/var/backups/backintime/new_snapshot/backup/"" returns 0

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: backintime-gnome 0.9.26-3ubuntu1
ProcVersionSignature: Ubuntu 2.6.32-22.33-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-22-generic i686
Architecture: i386
CheckboxSubmission: 8b15f4fca5292e90a3327d5e528e925e
CheckboxSystem: 988b7c9be54a1e2525cae7d97805a134
Date: Wed Jun 2 14:32:04 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_CA.utf8
 SHELL=/bin/bash
SourcePackage: backintime

[Jonathan Wiltshire (jwiltshire)]

Hi,

Please attach the file /home/mikelifeguard/.config/backintime/config which contains your BackInTime configuration for upstream to investigate.

Thanks.

[Dan (danleweb)]

You have:

snapshots.exclude_patterns=.*:*.backup*:*~:/home/mikelifeguard/Videos:/home/mikelifeguard/Pictures:/home/mikelifeguard/Downloads:/home/mikelifeguard/backups:/home/mikelifeguard/Music

snapshots.include_folders=/home/mikelifeguard|0

I see no problem in rsync command. Can you explain what you find strage in it ?

[Mike.lifeguard (mikelifeguard)]

--exclude="/var/backups" is in there twice, and the following don't make sense to me:
--include="//"
--exclude=".*"
--include="//**"
--exclude="*"

[jerico (jerico-dev)]

I'm affected by the same problem. When trying to back up '/' the rsync command simply doesn't select any files for backup. The rsync command will only work if you leave out the include/exclude parts Mike.lifeguard mentioned.

[jerico (jerico-dev)]

BTW: I'll try to fix this and send you a debdiff.

[jerico (jerico-dev)]

The attached patch works for me. As it changes the logic for treating included dirs a bit it should be reviewed with care before general inclusion into the package.

[Launchpad Janitor (janitor)]

This bug was fixed in the package backintime - 0.9.26-4

---------------
backintime (0.9.26-4) unstable; urgency=low

  * debian/control: depend on the menu packages for both GNOME and KDE
    front-ends, so we can use su-to-root on headless systems (LP:
    #466088)
  * Patch allow-root-backup.patch: allow backup of root directory,
    cherry-picked from upstream (LP: #588841) - thanks to jerico
  * Explicitly declare source format 1.0
  * Standards version 3.9.0 (no changes)
 -- Jonathan Wiltshire <email address hidden> Tue, 20 Jul 2010 16:38:22 +0100