ASSERT: "samples_needed >= 0" in file src/engine/readaheadmanager.cpp when holding finger on MIDI controller during scratching
Bug #588729 reported by
Sean M. Pappalardo
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mixxx |
Fix Released
|
High
|
Phillip Whelan |
Bug Description
Trunk r2407 introduced a bug that causes the following error when using a MIDI controller with the new scratch behavior and just holding my finger so the track is stopped. (Can be exaserbated by lower latency and toggling Play while holding the track.)
Fatal: []: ASSERT: "samples_needed >= 0" in file src/engine/
This happens on Linux and Windows. Tested with an SCS.3d.
Related branches
lp:mixxx/1.8
(Merged)
Changed in mixxx: | |
assignee: | mad (madjester) → Phillip Whelan (pwhelan) |
Changed in mixxx: | |
status: | Confirmed → Fix Committed |
Changed in mixxx: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Albert, Sean and I tracked this down to samples_needed going negative in EngineBufferSca leLinear. The logic to subtract the remainder was subtracting from samples_needed such that it went negative. In r2407, two asserts in EBSL that verify that samples_needed is greater than 0 were disabled, so the problem propagated to the RAMAN once EBSL tried to read with a negative samples_needed.