Mixxx

ASSERT: "samples_needed >= 0" in file src/engine/readaheadmanager.cpp when holding finger on MIDI controller during scratching

Bug #588729 reported by Sean M. Pappalardo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
Phillip Whelan
Mixxx 1.8.0

Bug Description

Trunk r2407 introduced a bug that causes the following error when using a MIDI controller with the new scratch behavior and just holding my finger so the track is stopped. (Can be exaserbated by lower latency and toggling Play while holding the track.)

Fatal: []: ASSERT: "samples_needed >= 0" in file src/engine/readaheadmanager.cpp, line 61

This happens on Linux and Windows. Tested with an SCS.3d.

Related branches

lp:mixxx/1.8 (Merged)
Sean M. Pappalardo (pegasus-renegadetech)
Changed in mixxx:
assignee: mad (madjester) → Phillip Whelan (pwhelan)
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Albert, Sean and I tracked this down to samples_needed going negative in EngineBufferScaleLinear. The logic to subtract the remainder was subtracting from samples_needed such that it went negative. In r2407, two asserts in EBSL that verify that samples_needed is greater than 0 were disabled, so the problem propagated to the RAMAN once EBSL tried to read with a negative samples_needed.

Phillip Whelan (pwhelan)
Changed in mixxx:
status: Confirmed → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5411

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.