poppy sftp tests lack proper test isolation

Bug #588420 reported by Aaron Bentley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Steve Kowalik

Bug Description

When I run the poppy tests, I am prompted me for my local SSH credentials (apparently via seahorse), and if I don't supply them, it fails:

$ bin/test -t poppy
Running canonical.testing.layers.ZopelessAppServerLayer tests:
  Set up canonical.testing.layers.BaseLayer in 0.002 seconds.
  Set up canonical.testing.layers.ZopelessLayer in 7.502 seconds.
  Set up canonical.testing.layers.DatabaseLayer in 0.503 seconds.
  Set up canonical.testing.layers.LibrarianLayer in 13.998 seconds.
  Set up canonical.testing.layers.MemcachedLayer in 0.127 seconds.
  Set up canonical.testing.layers.LaunchpadLayer in 0.000 seconds.
  Set up canonical.testing.layers.LaunchpadScriptLayer in 0.013 seconds.
  Set up canonical.testing.layers.LaunchpadZopelessLayer in 0.000 seconds.
  Set up canonical.testing.layers.ZopelessAppServerLayer in 16.344 seconds.

Error in test lp.poppy.tests.test_poppy.TestPoppy.test_full_source_upload(sftp)
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/abentley/launchpad/db-stable/lib/lp/poppy/tests/test_poppy.py", line 278, in test_full_source_upload
    transport.put_file(file_to_upload, fake_file, mode=None)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 490, in put_file
    return self._put(final_path, f, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 496, in _put
    fout = self._sftp_open_exclusive(tmp_abspath, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 861, in _sftp_open_exclusive
    path = self._get_sftp()._adjust_cwd(abspath)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 397, in _get_sftp
    connection, credentials = self._create_connection()
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 389, in _create_connection
    self._host, self._port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 330, in connect_sftp
    t = self._connect(username, password, host, port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 326, in _connect
    _paramiko_auth(username, password, host, port, t)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 530, in _paramiko_auth
    % (username, host, supported_auth_types))
ConnectionError: Connection error: Unable to authenticate to SSH host as
  joe@localhost
supported auth types: []
------------

Error in test lp.poppy.tests.test_poppy.TestPoppy.test_mkdir(sftp)
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/abentley/launchpad/db-stable/lib/lp/poppy/tests/test_poppy.py", line 218, in test_mkdir
    transport.mkdir('foo/bar', mode=None)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 662, in mkdir
    self._mkdir(self._remote_path(relpath), mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 638, in _mkdir
    self._get_sftp().mkdir(abspath, local_mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 397, in _get_sftp
    connection, credentials = self._create_connection()
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 389, in _create_connection
    self._host, self._port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 330, in connect_sftp
    t = self._connect(username, password, host, port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 326, in _connect
    _paramiko_auth(username, password, host, port, t)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 530, in _paramiko_auth
    % (username, host, supported_auth_types))
ConnectionError: Connection error: Unable to authenticate to SSH host as
  joe@localhost
supported auth types: []
------------

Error in test lp.poppy.tests.test_poppy.TestPoppy.test_rmdir(sftp)
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/abentley/launchpad/db-stable/lib/lp/poppy/tests/test_poppy.py", line 232, in test_rmdir
    transport.mkdir('foo/bar')
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 662, in mkdir
    self._mkdir(self._remote_path(relpath), mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 638, in _mkdir
    self._get_sftp().mkdir(abspath, local_mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 397, in _get_sftp
    connection, credentials = self._create_connection()
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 389, in _create_connection
    self._host, self._port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 330, in connect_sftp
    t = self._connect(username, password, host, port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 326, in _connect
    _paramiko_auth(username, password, host, port, t)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 530, in _paramiko_auth
    % (username, host, supported_auth_types))
ConnectionError: Connection error: Unable to authenticate to SSH host as
  joe@localhost
supported auth types: []
------------

Error in test lp.poppy.tests.test_poppy.TestPoppy.test_single_upload(sftp)
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/abentley/launchpad/db-stable/lib/lp/poppy/tests/test_poppy.py", line 252, in test_single_upload
    transport.put_file('foo/bar/baz', fake_file, mode=None)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 490, in put_file
    return self._put(final_path, f, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 496, in _put
    fout = self._sftp_open_exclusive(tmp_abspath, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 861, in _sftp_open_exclusive
    path = self._get_sftp()._adjust_cwd(abspath)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 397, in _get_sftp
    connection, credentials = self._create_connection()
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 389, in _create_connection
    self._host, self._port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 330, in connect_sftp
    t = self._connect(username, password, host, port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 326, in _connect
    _paramiko_auth(username, password, host, port, t)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 530, in _paramiko_auth
    % (username, host, supported_auth_types))
ConnectionError: Connection error: Unable to authenticate to SSH host as
  joe@localhost
supported auth types: []
------------

Error in test lp.poppy.tests.test_poppy.TestPoppy.test_upload_isolation(sftp)
Traceback (most recent call last):
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/runtest.py", line 128, in _run_user
    return fn(*args)
  File "/home/abentley/launchpad/stable/eggs/testtools-0.9.2-py2.5.egg/testtools/testcase.py", line 368, in _run_test_method
    testMethod()
  File "/home/abentley/launchpad/db-stable/lib/lp/poppy/tests/test_poppy.py", line 308, in test_upload_isolation
    conn_one.put_file('test', fake_file, mode=None)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 490, in put_file
    return self._put(final_path, f, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 496, in _put
    fout = self._sftp_open_exclusive(tmp_abspath, mode=mode)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 861, in _sftp_open_exclusive
    path = self._get_sftp()._adjust_cwd(abspath)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 397, in _get_sftp
    connection, credentials = self._create_connection()
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/sftp.py", line 389, in _create_connection
    self._host, self._port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 330, in connect_sftp
    t = self._connect(username, password, host, port)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 326, in _connect
    _paramiko_auth(username, password, host, port, t)
  File "/home/abentley/launchpad/stable/eggs/bzr-2.1.0-py2.5-linux-x86_64.egg/bzrlib/transport/ssh.py", line 530, in _paramiko_auth
    % (username, host, supported_auth_types))
ConnectionError: Connection error: Unable to authenticate to SSH host as
  joe@localhost
supported auth types: []
------------

  Ran 5 tests with 0 failures and 5 errors in 46.425 seconds.
Running canonical.testing.layers.ZopelessDatabaseLayer tests:
  Tear down canonical.testing.layers.ZopelessAppServerLayerNo handlers could be found for logger "lazr.smtptest"
 in 0.508 seconds.
  Tear down canonical.testing.layers.LaunchpadZopelessLayer in 0.000 seconds.
  Tear down canonical.testing.layers.LaunchpadScriptLayer ... not supported
  Running in a subprocess.
  Set up canonical.testing.layers.BaseLayer in 0.004 seconds.
  Set up canonical.testing.layers.ZopelessLayer in 5.407 seconds.
  Set up canonical.testing.layers.DatabaseLayer in 0.372 seconds.
  Set up canonical.testing.layers.ZopelessDatabaseLayer in 0.000 seconds.
  Ran 6 tests with 0 failures and 0 errors in 40.359 seconds.
  Tear down canonical.testing.layers.ZopelessDatabaseLayer ... not supported
  Tear down canonical.testing.layers.ZopelessLayer ... not supported
  Tear down canonical.testing.layers.DatabaseLayer in 0.221 seconds.
  Tear down canonical.testing.layers.BaseLayer in 0.000 seconds.
Running zope.testing.testrunner.layer.UnitTests tests:
  Running in a subprocess.
  Set up zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
  Ran 45 tests with 0 failures and 0 errors in 0.089 seconds.
  Tear down zope.testing.testrunner.layer.UnitTests in 0.000 seconds.
Total: 56 tests, 0 failures, 5 errors in 2 minutes 43.773 seconds.

Related branches

Changed in soyuz:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Steve Kowalik (stevenk)
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
Changed in soyuz:
milestone: none → 10.06
status: In Progress → Fix Committed
tags: added: qa-needstesting
Steve Kowalik (stevenk)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.