Products.LDAPUserFolder

Duplicate servers

Bug #586967 reported by Ben Liles on 2010-05-28

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Products.LDAPUserFolder	Fix Released	Medium	Unassigned

Bug Description

The code in trunk wasn't detecting that there was an existing server with the same host/port due to issues comparing strings and integers. Also, when it did identify that a server already existed, it didn't set the timeouts that were sent in.

Attached is a patch that handles both of these cases.

Tags:

Revision history for this message

Ben Liles (bliles) wrote on 2010-05-28:

Patch for LDAPDelegate.py Edit (2.2 KiB, text/plain)

Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount) on 2010-05-30

Changed in ldapuserfolder:
status:	New → Confirmed
importance:	Undecided → Medium
assignee:	nobody → Jens Vagelpohl (jens-dataflake)

Revision history for this message

Jens Vagelpohl (dataflake-deactivatedaccount-deactivatedaccount) wrote on 2010-05-30:

Ben, please note that no releases are made from trunk, and trunk is not in a stable state at all. Trunk will become version 3.0, which will carry backwards-incompatible changes. It's also possible that trunk may not yield any release ever, this depends on work I will be doing on the LDAPMultiPlugins package. I may end up advising users to switch to a combination of PluggableAuthService and LDAPMultiPlugins as a full replacement for the "simple" LDAPUserFolder.

All releases in the 2.x release series are made from the branch named "2":

http://svn.dataflake.org/viewvc/Products.LDAPUserFolder/branches/2/

That means if you want to submit patches, please create them against this release branch instead.

I have put in a slightly different fix:

http://svn.dataflake.org/viewvc?view=revision&revision=1971

By the way, I always appreciate tests to accompany patches. If a patch has no tests and it is not relatively easy to write them the issue may languish when I don't have time.