FTP upload not working

[Julien Marchand]

The FTP upload does not work due to two little things :

Traceback (most recent call last):
  File "/usr/bin/lookit", line 139, in capture_screen
    self.process_pixbuf(pb)
  File "/usr/bin/lookit", line 147, in process_pixbuf
    self.upload_image(hashstring)
  File "/usr/bin/lookit", line 169, in upload_image
    self.prefs['url'],
  File "/usr/lib/pymodules/python2.6/lookit/uploader.py", line 78, in upload_file_ftp
    f = ftplib.FTP()
NameError: global name 'ftplib' is not defined

(ftplib is not imported)

Traceback (most recent call last):
  File "/usr/bin/lookit", line 139, in capture_screen
    self.process_pixbuf(pb)
  File "/usr/bin/lookit", line 147, in process_pixbuf
    self.upload_image(hashstring)
  File "/usr/bin/lookit", line 169, in upload_image
    self.prefs['url'],
  File "/usr/lib/pymodules/python2.6/lookit/uploader.py", line 86, in upload_file_ftp
    print f.storbinary('STOR ' + f, i)
TypeError: cannot concatenate 'str' and 'instance' objects

(f is the filename of the file to upload, and is later owerwritten as an instance of ftplib.FTP())

A diff that fixes the problem is attached.

[Zach Tibbitts (zachtib)]

thanks! I need to start reviewing my source after I come down off my coffee binges...

[Julien Marchand (jmarchan)]

You're welcome ! Nice software :)