Booleans in syncdaemon.State should be always booleans
Bug #584290 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| magicicada gui |
Fix Released
|
Critical
|
Facundo Batista | ||
Bug Description
_on_status_changed may set the booleans attributes for current_state (is_xxx) to string instead of boolean.
I suggest setting the state using the bool() values instead of doing self.current_
Related branches
lp:~facundo/magicicada-gui/fake-dbus
- Natalia Bidart: Approve
-
Diff: 2583 lines (+1509/-752)6 files modifiedmagicicada/dbusiface.py (+288/-0)
magicicada/syncdaemon.py (+104/-233)
magicicada/tests/helpers.py (+49/-0)
magicicada/tests/test_dbusiface.py (+665/-0)
magicicada/tests/test_magicicada.py (+4/-3)
magicicada/tests/test_syncdaemon.py (+399/-516)
| Changed in magicicada: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| assignee: | nobody → Facundo Batista (facundo) |
| Changed in magicicada: | |
| importance: | High → Critical |
| tags: | added: magicicada-alpha1 |
| Changed in magicicada: | |
| status: | Confirmed → Fix Committed |
| Changed in magicicada: | |
| milestone: | none → alpha1 |
| tags: | removed: magicicada-alpha1 |
| Changed in magicicada: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
