lp-propose could ask for two reviews for bzr projects

[Robert Collins]

Bzr has a 2-core reviews policy. lp-propose could help with that by asking for reviews based on some policy. E.g. it could look and see if the project has a tag in the description, or is called bzr-* or is in the bazaar project group, and if it is see if the proposer is a member of the review team (ask for 1 review) or not (ask for 2 reviews).

Its true that Launchpad's web UI wouldn't enforce the policy, but this would let us have a smoother workflow, find issues with using multiple reviews and then when its working well we could raise having a config for this in the core.

[Martin Pool (mbp)]

I think it's impossible to implement this on top of Launchpad at the
moment: you can only request one review from any person or team at a
time. We could file a second bug.

More generally perhaps it would be useful to have "lp-propose
--request lifeless,bzr-core"

--
Martin <http://launchpad.net/~mbp/>

[Robert Collins (lifeless)]

You can do --review=lifeless --review=bzr-core today, I think -
looking at the code.

If lp can't have two outstanding reviews to a proposal today, then yes
we should file a bug on that.

[Aaron Bentley (abentley)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/21/2010 03:35 AM, Robert Collins wrote:
> You can do --review=lifeless --review=bzr-core today, I think -
> looking at the code.
>
> If lp can't have two outstanding reviews to a proposal today, then yes
> we should file a bug on that.

It can't have two for a given person or team.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkv4LWgACgkQ0F+nu1YWqI1kdQCfbUazi63Exy3TehKIyTrjxRa3
SiwAnj0EELuH6M9HZfHBL3WZ/WSnxMap
=L18O
-----END PGP SIGNATURE-----

[Robert Collins (lifeless)]

Ok, filed https://bugs.edge.launchpad.net/launchpad-code/+bug/584352
to track that.

[Robert Collins (lifeless)]

Two reviews from one reviewer works on staging.