CSV export crash when browse null is in some relations

[Nicolas Bessi - Camptocamp]

CSV export generates client side error can not marshal osv.orm.browse_null.

The error comes from the fact in that browse_null are exported instead of false.
I have made a temporary patch that remove the browse_null, but I did not have the time to trace the export functions (that lack a little comments), so the patch can be far better.

Regards

Nicolas

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Nicolas,

I would prefer to generate the situation where I can face the problem.

Would you please tell us the steps you followed?

Thanks.

[Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan)]

Here's the patch I did.

You can easily reproduce this by trying to export a field of a relation which doesn't exist. For example, create a picking without address and try to export address' name.

[Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount)]

The patch of Albert is far better than mine.

Regards

Nicolas

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello,

I wonder how it crashes.

There is a method check_type() which will always give you the corresponding null value(0,0.00,False,'').

However, I am still trying to generate the error by some reverse-engineering (checking how can I forcefully generate).

Thanks.

[Albert Cervera i Areny - http://www.NaN-tic.com (albert-nan)]

Hi Jay,
have you tried to reproduce it with the given example: "create a picking without address and try to export address' name."?

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Albert,

Yes, I tried the same way out.

Doesn't the method check_type() resists the problem at your end?

Thanks.

[Samantha (samantha-z-mathews)]

no luck to re-birth is at my station.

[Mikel Ruiz (mkruiz)]

Hello,

I know this bug is a bit old, but I have the same problem here. Albert's patch works perfectly.

Jay: the problem with check_type() is that it's only called if the column exists either in self._columns or in self._inherit_fields. When exporting fields from related fields (i.e. when the column doesn't belong to the current object) the column types aren't available. Maybe this is the real bug (?) and it should really never happen.

To reproduce, try going to Sales Management/Sales Orders, create one entry with a shipping address without country and then export Shipping Address/Country/Contry Code. At that point 'country_id' isn't found in self._columns or in self._inherit_fields and check_type isn't called.

Regarding the proposed patch, I find defaulting to an empty string when marshaling a null object (of an unknown column type) is much better than crashing.

Thanks!

[Mikel Ruiz (mkruiz)]

By the way, I think that the second part of the patch is unnecessary as data[fpos] = tools.ustr(r or '') should do the job.

[Amit Parik (amit-parik)]

Hello,

I have checked this issue with latest trunk and it is working fine.

So this issue only effect for the stable version5.

For this type of stable version's issue, If you have a support and maintenance contact with us then you can contact with our OPW team at <email address hidden>, they will definitely help you.

Thank you!