Crash when deleting all tasks (negative task count?)

[Luca Invernizzi]

- start gtg with the default tasks set
- F9
- remove all task
you should see a negative number besides "All tasks" and "Tasks with no tags". This is obviously wrong.

[Bryce Harrington (bryce)]

I tried reproducing this, but instead of seeing a negative number, it crashed. I started it up, selected all tasks, right clicked, picked 'Delete', and "Permanently remove tasks". Crash dump follows:

Setting XDG vars to use default dataset.
/home/bryce/src/gtg/gtg/GTG/taskbrowser/browser.py:855: GtkWarning: gtk_tree_model_sort_build_level: assertion `length > 0' failed
  self.ctask_tv.set_model(ctask_modelsort)
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/viewmanager/delete_dialog.py", line 42, in on_delete_confirm
    self.req.delete_task(tid)
  File "/home/bryce/src/gtg/gtg/GTG/core/requester.py", line 211, in delete_task
    for tag in task.get_tags():
AttributeError: 'NoneType' object has no attribute 'get_tags'

1@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

1@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

2@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

3@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

3@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

4@1 is modified in the filteredtree
Traceback (most recent call last):
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 195, in __task_modified
    inroot = self.__is_root(self.get_node(tid))
  File "/home/bryce/src/gtg/gtg/GTG/core/filteredtree.py", line 611, in __is_root
    if not self.flat and n.has_parent():
AttributeError: 'NoneType' object has no attribute 'has_parent'

5@1 is modified in the filteredtree
Traceback (most recent call last):
  F...

[Bryce Harrington (bryce)]

Re-starting the program after the crash, the tasks were gone. The following warnings were shown:

$ ./scripts/debug.sh
Setting XDG vars to use default dataset.
/home/bryce/src/gtg/gtg/GTG/taskbrowser/browser.py:217: GtkWarning: gtk_tree_model_sort_build_level: assertion `length > 0' failed
  self.task_tv.set_model(self.task_modelsort)
/home/bryce/src/gtg/gtg/GTG/taskbrowser/browser.py:855: GtkWarning: gtk_tree_model_sort_build_level: assertion `length > 0' failed
  self.ctask_tv.set_model(ctask_modelsort)

[Bryce Harrington (bryce)]

I tested doing <Dismiss> on all tasks, and <Mark as Done> on all tasks using shortcut keys, menus, context menus, etc. but could not reproduce the original behavior of the negative counts.

However, <Delete> produces the same crash reliably whether from a menu, shortcut, etc.

[Bryce Harrington (bryce)]

I'm bumping up the priority on this and changing the title to match what I was able to reproduce. Hope that's ok.

[Lionel Dricot (ploum-deactivatedaccount)]

fixed in rev 785