[sale] inconsistent workflow status check for sale.order

[Raphaël Valyi - http://www.akretion.com]

Hello,

Under some circumstances (can't remember exactly the manipulation but is related to picking/invoice cancellation), the "sale.order" workflow can become stuck because of a wrong check.

Indeed, the sale.order can by definition have only the following states:
        'state': fields.selection([
            ('draft', 'Quotation'),
            ('waiting_date', 'Waiting Schedule'),
            ('manual', 'Manual In Progress'),
            ('progress', 'In Progress'),
            ('shipping_except', 'Shipping Exception'),
            ('invoice_except', 'Invoice Exception'),
            ('done', 'Done'),
            ('cancel', 'Cancelled')
            ]

But in the sale.order#action_invoice_create method, we check the state against:
states=['confirmed', 'done', 'exception']
the "exception" state simply doesn't exist or doesn't exist anymore. I guess "invoice_except" should be used instead.

BTW, I'm not a pythonista, but I find it strange to test things against strings, I would have used constants in order to avoid using such strings mismatch, at least that's how Java, C++ guys would do and I'm pretty sure this would be a good practise in Python too.

I had to apply the following patch (also attached) to make it work:

=== modified file 'sale/sale.py'
--- sale/sale.py 2010-04-08 13:39:40 +0000
+++ sale/sale.py 2010-05-11 19:55:07 +0000
@@ -407,7 +407,7 @@
         inv_obj.button_compute(cr, uid, [inv_id])
         return inv_id

- def action_invoice_create(self, cr, uid, ids, grouped=False, states=['confirmed', 'done', 'exception']):
+ def action_invoice_create(self, cr, uid, ids, grouped=False, states=['confirmed', 'done', 'invoice_except']):
         res = False
         invoices = {}
         invoice_ids = []

Hope this helps.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Raphaël Valyi ,

The state check being made at action_invioce_create() is upto the mark and it should have the list of states of sale order line,not of Sale Order.

The aim of putting such a check is, if the sale order line is not among those listed states(a draft line), can be invoiced.

I wonder when could it have blocked you?
Hope this helps.
Thanks.