Bzr talks to edge to translate lp:foo type urls

Bug #581670 reported by Tom Haddon
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Bazaar
Fix Released
Medium
Martin Packman
Launchpad itself
Invalid
Undecided
Unassigned

Bug Description

Bzr talks to edge to translate lp:foo type urls into bzr+ssh://bazaar.launchpad.net/~user/foo/trunk or http://bazaar.launchpad.net/~user/foo/trunk URLs.

To quote Michael Hudson from an RT ticket:

"Historically it's something to do with Python's XML-RPC client library not handling redirects well, and the prod -> edge redirect occasionally screwed things up. I don't know if these recollections are right and even less if the reasons still apply."

It seems to be a bad thing to be using edge for a production service like this.

Related branches

Revision history for this message
Aaron Bentley (abentley) wrote :

I thought we did it because on a particular release, production was broken, but edge worked.

Revision history for this message
Tom Haddon (mthaddon) wrote :

That's possible, but it's not a good reason to keep it there.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

In the meantime, the env variable BZR_LP_XMLRPC_URL=http://xmlrpc.launchpad.net/bazaar/ can be set to work around the default.

Revision history for this message
Данило Шеган (danilo) wrote :

We should probably use the work-around in translations if it doesn't get fixed soon enough.

Revision history for this message
Jonathan Lange (jml) wrote :

Danilo, why don't you just fix it?

Revision history for this message
Данило Шеган (danilo) wrote :

Because I have a million things to deal with right now, and this is a very low priorty for us compared to the other stuff we are dealing with.

Revision history for this message
Martin Packman (gz) wrote :

Submitted a branch with the swap over done for the bzr launchpad plugin, not sure if there's other changes needed elsewhere.

Changed in bzr:
assignee: nobody → Martin [gz] (gz)
Revision history for this message
Martin Packman (gz) wrote :

Change moving launchpad plugin over to production landed in r5244. One part had to be backed out due to bug 583667 Robert encountered with lp-propose, but that's unrelated to xml rpc.

This bug is filed against three projects, is there any further work here that needs doing?

Revision history for this message
Robert Collins (lifeless) wrote :

translations probably wants to cherrypick the two commits we made for this (5244 + 5247) because it was filed to address a production issue they are having with lp: resolution.

Changed in launchpad-code:
status: New → Invalid
Changed in bzr:
status: New → Fix Released
importance: Undecided → Medium
milestone: none → 2.2b3
Changed in rosetta:
status: New → Invalid
status: Invalid → Triaged
importance: Undecided → High
milestone: none → 10.05
Tom Haddon (mthaddon)
tags: added: canonical-losa-lp
Changed in rosetta:
milestone: 10.05 → 10.06
Curtis Hovey (sinzui)
Changed in rosetta:
milestone: 10.07 → 10.08
Revision history for this message
Данило Шеган (danilo) wrote :

Next steps for deploying the fix:
 * make sure ports are open in the firewall between cesium and xmlrpc.lp.net
 * get bzrlib revisions which fix this onto cesium
 * close out ports between cesium and xmlrpc.edge.lp.net
 * test everything that might be trying to access bzr branches from cesium

FWIW, this could be affecting daily builds stuff as well, though I don't really know for sure. At the very least, it'd have to be tested properly before a fix is rolled out.

Revision history for this message
Данило Шеган (danilo) wrote :

I am expecting bzr update for Launchpad early next cycle.

Changed in rosetta:
milestone: 10.08 → 10.09
Changed in rosetta:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.