Person merge code does not take into account inactive and proposed memberships
Bug #58138 reported by
Diogo Matsubara
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Unassigned |
Bug Description
Steps to reproduce (using sample data):
1. Log in as Sample Person;
2. Open http://
3. Fill in 'Duplicated Account': spiv; Note that spiv is an proposed member in
ubuntu-team
4. Click Submit;
5. Open http://
Andrew Bennetts (spiv-merged) as one of the proposed members.
A merged person shouldn't appear in that list.
Also note that if you access
http://
appears in that list and you can even approve his membership request.
Related branches
lp:~sinzui/launchpad/merge-memberships
- Benji York (community): Approve (code)
-
Diff: 71 lines (+36/-0)2 files modifiedlib/lp/registry/model/person.py (+18/-0)
lib/lp/registry/tests/test_personset.py (+18/-0)
Changed in launchpad: | |
assignee: | stub → nobody |
description: | updated |
Changed in launchpad-registry: | |
importance: | Medium → Low |
status: | Confirmed → Triaged |
tags: |
added: merge-deactivate removed: registry |
tags: | added: teams users |
tags: | added: canonical-losa-lp |
Changed in launchpad: | |
assignee: | nobody → Curtis Hovey (sinzui) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
Note that due to the (person, team) unique key for team memberships, the merge code should handle the case where both people being merged have team membership records.