serial settings in openDCC dialog not recognized

[gramels]

rocrail and openDCC somehow dont agree on the serial speed settings

openDCC expressnet firmware 0.23.4
rocrail >1600

Test pattern:
in openDCC command station dialogue
*read CV
*change speed in rocrail dialog to e.g. 57600
*write CV
*restart rocrail & openDCC
->connection lost
*set openDCC speed manually to 2400
*restart rocrail
->can connect
*read CV
->openDCC seems to be set to speed setting 0 (2400)

This would also explain new users problems getting openDCC and rocrail connected.

I suspect that rocrail is confused with the fact, depending on the protocol settings of openDCC (expressnet or p50x) the baud mapping is different: http://www.opendcc.de/elektronik/opendcc/opendcc_doc_so.html .

[Ernst Gill (ernst-gill)]

Sorry, I overlooked this during my test.

There is a problem with the baudrate interpretation in RocRail.

As far as I could see the following happens:
When you change the baudrate the wrong value is send to Open DCC
e.g. for 57600 baud it should send 3 but it sends 5.
This happens because OpenDCC expects at write the Lenz values,
but for reads OpenDCC provides the p50xb values.

Ernst

[Rocrail (r.j.versluis)]

Read all SO's first to send the correct value.
The internal evaluation needs to know if the firmware id p50x or xpressnet.

[Rocrail (r.j.versluis)]

Or select the correct protocol manually before writing the BPS to OpenDCC.

[gramels (lothar-gramelspacher)]

I would like to suggest to default to p50x since this is what most newbies use and what Wolfgang recommends and provides pre-compiled:

http://opendcc.foren-city.de/topic,50,-firmware-fuer-xpressnet-oder-p50x.html

[Rocrail (r.j.versluis)]

To assume a default is not correct because p50x and xpressnet are different for this SO.

[Ernst Gill (ernst-gill)]

Hi,

Please find attached all files I have changed to fix
some more bugs and missing implementations for OpenDCC.

The following bugs are fixed:
  - baurate problem
  - wrong or missing text for S88 tab

The following missing implementations I have done (I have
requested at my last bugfixing, but it was simple ignored.
I did not even get a simple 'NO'.):
  - OpenDCC box serial number (SO39)
  - XpressNet feedback mapping (SO29)

I implement all missing functions with DialogsBlocks 4.37
(as suggested on your webside). Please take a look at my
implementation if all is correct and looks like it should.

I did also add the 'txt' and 'tip' for the missing functions in
file messages.xml, but only for english and german language.
Hopefully someone could add all the other languages.

The tests about the 'Decoder' 'Exceptions' are still open.
I am currently not able to test this (due of a missing database).
So, if someone could test this it would be very helpfull.

Ernst

[Rocrail (r.j.versluis)]

Hi Ernst,

thanks for your coding; I will check it this week and merge it into the main trunk of development.

> I have requested at my last bugfixing, but it was simple ignored.
> I did not even get a simple 'NO'.
It was not rejected, but I'm doing Rocrail in spare time and sometimes when reports contain more than one issue it can be overlooked or just forgotten. Also there are more issues open. I pick one which I like todo or I do an implementation of something which I'm interested in.

Best regards,
Rob.

P.S.: Just ping if you do not get any response at all. ;-)

[Ernst Gill (ernst-gill)]

Hi,

Sorry I forgot:

The file message.xml is not the latest one.
So you may need to merge it.

Ernst

[Rocrail (r.j.versluis)]

I merged it in 1621.

Even after removing the DOS line breaks the diff is too big for human compare.
This is always an issue when using DialogBlocks. This is the main reason for using wxFormBuilder for new dialogs.

Please check the merge and report any difficulties.

[Rocrail (r.j.versluis)]

BTW: Please use the coding guide lines to keep source comparable.
http://wiki.rocrail.net/doku.php?id=coding-guide-en

[Ernst Gill (ernst-gill)]

Hi,

I test 1621, everything looks o.k. and is working as expected.

> BTW: Please use the coding guide lines to keep source comparable.
Do you mean the DOS line breaks ? If so, this was DialogBlocks.
Sorry I have overlooked this.

> It was not rejected, but I'm doing Rocrail in spare time and sometimes
> when reports contain more than one issue it can be overlooked or just
> forgotten. Also there are more issues open. I pick one which I like todo
> or I do an of implementationsomething which I'm interested in.

It was just a jocke, your are doing a great job with Rocrail !!!

As you see, if no one is implementig my wishes, I do it on my own.

Ernst