Problem when using show bothh option and more than 2 duplicates

Bug #579902 reported by mihai.ile
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rhythmbox Duplicate Source
Fix Committed
Medium
Unassigned

Bug Description

Hello.
using revision 3 I found that if I have 3 duplicates of the same file and the option to show both original and it's duplicate in the source, the plugin does not work as it tries to add the original (actually the middle file 2 times)

So by the code,
We have the duplicates i, i+1, i+2

first it adds file "i" and "i+1"
then i=i+1
then tries to add "i" and "i+1", but the "i" is actually the old "i+1" that was added already.

anyway I add this patch to fix the problem, and it works like a charm this way, no warnings, nothing.
Actually the place in the code I fixed this could help avoid further bugs of this type. (the problem in my view is not the while loop, but the add entry method)

Revision history for this message
mihai.ile (mihai.ile) wrote :
Changed in rb-duplicate-source:
importance: Undecided → Medium
assignee: nobody → scrawl (scrawl)
status: New → Confirmed
Changed in rb-duplicate-source:
status: Confirmed → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.