File uploads don't refresh the file-browser when complete

Bug #579043 reported by David Coles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
IVLE
Fix Released
Low
David Coles

Bug Description

Firefox 3.5.9

File uploads don't refresh the file browser when complete or close the upload dialog.
Have to refresh the page by hand.

Related branches

William Grant (wgrant)
Changed in ivle:
milestone: none → 1.0.2
David Coles (dcoles)
Changed in ivle:
assignee: nobody → David Coles (dcoles)
Revision history for this message
David Coles (dcoles) wrote :

Looks like this is caused by some odd DOM behaviour that causes the JSON to be split into several DOM nodes. Thus firstChild results in truncated JSON. This causes an JSON parse error and thus refresh fails.

browser.js
----
401: data = myFrame.firstChild.getElementsByTagName(
402: 'body')[0].firstChild.firstChild.nodeValue;
403: data = JSON.parse(data)

Solution is probably to use something like `innerText` rather than `firstChild.nodeValue`.

tags: added: webkit
David Coles (dcoles)
Changed in ivle:
status: Triaged → In Progress
Revision history for this message
David Coles (dcoles) wrote :

Using `value = x.innerText || x.innerContent;` to get content of nodes. innerText is supported by IE, but not Firefox. The DOM3 innerContent is supported by Firefox but not IE. Webkit supports either form.

Changed in ivle:
status: In Progress → Fix Committed
William Grant (wgrant)
Changed in ivle:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.