feed polling errors don't tell you which feed is broken

[Stefano Rivera]

2010-05-10 19:52:16,082 ERROR plugins: Periodic method failing: Retrieve.poll
Traceback (most recent call last):
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/__init__.py", line 179, in _run_periodic_handler
    method(event)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/feeds.py", line 292, in poll
    feed.update(max_age=self.interval)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/feeds.py", line 87, in update
    re.sub(r'\W+', '_', self.name), self.identity_id), headers)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/utils/__init__.py", line 66, in cacheable_download
    f = _cacheable_download(url, cachefile, headers, timeout)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/utils/__init__.py", line 114, in _cacheable_download
    connection = urllib2.urlopen(req, **kwargs)
  File "/usr/lib/python2.5/urllib2.py", line 124, in urlopen
    return _opener.open(url, data)
  File "/usr/lib/python2.5/urllib2.py", line 387, in open
    response = meth(req, response)
  File "/usr/lib/python2.5/urllib2.py", line 498, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python2.5/urllib2.py", line 425, in error
    return self._call_chain(*args)
  File "/usr/lib/python2.5/urllib2.py", line 360, in _call_chain
    result = func(*args)
  File "/usr/lib/python2.5/urllib2.py", line 506, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
HTTPError: HTTP Error 404: Not Found

That tells me nothing.

[Max Rabkin (max-rabkin)]

What is the correct behaviour here? Output the name of the error-causing feed to logs, and skip the notification?

[Stefano Rivera (stefanor)]

> What is the correct behaviour here? Output the name of the error-causing
> feed to logs, and skip the notification?

Sounds good.

Obviously there's some general logic to handle failing periodic functions. You may need to completely ignore that here.

[Max Rabkin (max-rabkin)]

It wouldn't be difficult to add support "join #channel with keyword foo", but how would it be specified in config?

[Max Rabkin (max-rabkin)]

Oops, wrong bug.