nssbackup-upgrade-backups and nssbackupd crashes when starting nssbackup-restoration-gui

[Joel Weinberger]

I just installed NSbackup to handle my backups I generated with sbackup. Thus, I began upgrading all of my backups using the nssbackup-upgrade-backups script. While that was working, I opened the "NSsbackup Restoration" gui. The gui opened, but that immediately crashed the nssbackup-upgrade-backups script and left one of my backups in a corrupted state.

Unfortunately, I was not clever enough to copy the python stack trace from the crash. It was completely reproducible for me, but I am in the middle of upgrading my backups after spending a while fixing the corrupt one by hand, so I do not have the ability to reproduce it on my machine at the moment.

I am running Ubuntu 10.04 Lucid and version 0.2-0~rc8-jaunty1 of NSsbackup. I installed this from PPA.

[Anton (feenstra)]

I find the same problem, however I still have my windows open ;-)
I'm running today's bzr source (0.3) on Lucid.
I was running sbackup from the Lucid repo till recently (this morning).

My backup repo is on ssh, but access seems not the problem because earlier steps succeeded (renaming file and making includes.list, excludes.list and 'format' file).

The error popup reads:

Unable to upgrade snapshot

While attempting to upgrade snapshot the following error occurred:
need more than 1 value to unpack

This is the relevant part of the terminal output, including the traceback:
2010-08-12 15:31:04,423 - INFO: Creating the SNAR file
2010-08-12 15:31:05,681 - ERROR: Error while upgrade snapshot: need more than 1 value to unpack
Traceback (most recent call last):
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/ui/SBRestoreGTK.py", line 778, in on_upgradeButton_clicked
    um.upgradeSnapshot(self.currentSnp)
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/core/UpgradeManager.py", line 107, in upgradeSnapshot
    self.__upgrade_v15(snapshot)
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/core/UpgradeManager.py", line 305, in __upgrade_v15
    if snarfileinfo.hasPath(parentdir) :
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/ar_backend/tar.py", line 1326, in hasPath
    for f in self.__snapshotFile.parseFormat2():
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/ar_backend/tar.py", line 1010, in parseFormat2
    yield format(currentline)
  File "/usr/local/lib/python2.6/dist-packages/nssbackup/ar_backend/tar.py", line 987, in format
    nfs, mtime_sec, mtime_nano, dev_no, i_no, name, contents = line.lstrip("\0").split("\0", 6)
ValueError: need more than 1 value to unpack

Please let me know if you need more info or test to track this down.

[Jean-Peer Lorenz (peer.loz)]

I've found an error that definitely can cause crashs though I'm not entirely sure if patching this does also fix the crash reported by Anton.

I'll commit the fix and set status of this bug to fixed. In the case of persistent errors please reopen it.