Oops on negative batch parameter

[Jeroen T. Vermeulen]

We got an oops in Translations yesterday: OOPS-1582C923

This user had hacked up a URL to set the batching parameter to -300, which breaks result-set slicing for the page.

It would be nice to have this kind of invalid parameter value caught right up front, just like the values greater than 300, so we don't get oopses on the individual Launchpad applications.

[Gary Poster (gary)]

Triaging as high because of OOPS policy

[Jeroen T. Vermeulen (jtv)]

Attaching the branch I wrote for this yesterday. Normally this would've happened automatically, but the branch scanner seems to be held up.

[Gary Poster (gary)]

Current status: jtv is making a release of lazr.batchnavigator and then preparing a branch of LP to use it. Assigning him the Foundations task as well, since the integration is the Foundations part.

[Ursula Junque (ursinha)]

Fixed in stable r10857 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10857>

[Diogo Matsubara (matsubara)]

I have just QA'ed this one with the following:
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=100, work as expected with a batch of 100 results
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=350, work as expected with an error page "Invalid Batch Size"
https://translations.staging.launchpad.net/ubuntu/karmic/+lang/nb/?start=0&batch=-300, work as expected ignoring the negative batch parameter, returning the default 50 results