Lyrics extension does not obey "Write metadata to files" preference

Bug #573996 reported by HorstBort
This bug report is a duplicate of:  Bug #586174: Banshee corrupts certain music files. Edit Remove
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
banshee-community-extensions (Ubuntu)
Fix Committed
High
Unassigned

Bug Description

Binary package hint: banshee-community-extensions

1) 10.04
2) 1.6.0-1ubuntu5
3) If the extension is enabled, track files are changed, apparently to write the lyrics to the file. Also, a hiccup in playback happens.
4) If the Banshee preference "Write metadata to files" is not enabled, the extension should not do so.

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: banshee-extension-lyrics 1.6.0-1ubuntu5
ProcVersionSignature: Ubuntu 2.6.32-21.32-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-21-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Sun May 2 22:54:54 2010
EcryptfsInUse: Yes
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_GB:en
 PATH=(custom, user)
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: banshee-community-extensions

Revision history for this message
HorstBort (haukemuentinga) wrote :
Revision history for this message
Chow Loong Jin (hyperair) wrote : Re: [Bug 573996] [NEW] Lyrics extension does not obey "Write metadata to files" preference

On Monday 03,May,2010 05:00 AM, HorstBort wrote:
> Public bug reported:
>
> Binary package hint: banshee-community-extensions
>
> 1) 10.04
> 2) 1.6.0-1ubuntu5
> 3) If the extension is enabled, track files are changed, apparently to write the lyrics to the file. Also, a hiccup in playback happens.
> 4) If the Banshee preference "Write metadata to files" is not enabled, the extension should not do so.

Could you provide the output of "banshee --debug"? As far as I know, the lyrics
extension only caches the lyrics in ~/.cache/banshee-1/extensions/lyrics. This
is by design, and it not what is meant by "Write metadata to files".

The hiccup in playback is likely a separate issue, though I'm not sure about this.

--
Kind regards,
Chow Loong Jin

Revision history for this message
HorstBort (haukemuentinga) wrote :

Here's the output from "banshee --debug":

[1 Debug 13:52:46.167] Player state change: Loaded -> Playing
[7 Debug 13:52:47.006] Error: ConnectFailure (Connection refused), http://api.leoslyrics.com/api_search.php?auth=duane&artist=Muse&songtitle=Resistance
[8 Debug 13:52:47.012] Error: ConnectFailure (Connection refused), http://api.leoslyrics.com/api_search.php?auth=duane&artist=Muse&songtitle=Resistance
[1 Debug 13:52:47.179] TrackInfoDisplay RenderAnimation: 33.00 FPS
[1 Debug 13:52:47.200] TrackInfoDisplay RenderAnimation: 33.00 FPS
[7 Debug 13:52:47.757] The remote server returned an error: (404) Not Found., http://www.lyriki.com/Muse:Resistance
[8 Debug 13:52:47.759] The remote server returned an error: (404) Not Found., http://www.lyriki.com/Muse:Resistance
[7 Debug 13:52:49.418] Lyrics successfully written /home/hauke/.cache/banshee-1/extensions/lyrics/Muse_Resistance.lyrics

Though, md5sum of the file changed during playback:

b4ede045721d638dde7841dc3d027e90 02 - Resistance.mp3
b81b9202f62230757ff5399ad189d8ea 02 - Resistance-pre-lyrics.mp3

This does not happen with lyrics extension disabled. Hiccup occurs at the same time as debug line "Lyrics successfully written ...".

Indeed, lyrics are written to the file (see attachment).

Revision history for this message
Chow Loong Jin (hyperair) wrote :

This bug has been fixed upstream in commit f12d70a1b2a3a0a380ecabfcf7a3b15fe0c989ae.

Revision history for this message
Chow Loong Jin (hyperair) wrote :
Changed in banshee-community-extensions (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.