OpenSRF log messages suggest code problem

[Jason Stephenson]

Evergreen trunk r16318
OpenSRF trunk r1951
PostgreSQL 8.4
Ubuntu Karmic Koala

The following message appears in the open-ils.storage_unix.log and possibly others:

Use of uninitialized value in join or string at /usr/local/share/perl/5.8.8/OpenSRF/Application.pm line 118.

The message appears during an attempt to log an OpenSRF request that requires no parameters. The attached patch makes the above message go away and causes the actual message to be logged with the string "undef" in the parameters. I believe the bug also affect OpenSRF 1.2 as the code in question does not appear to be different between 1.2 and trunk.

[Jason Stephenson (jstephenson)]

Actually, wasn't this patch applied at some point?

[Bill Erickson (berick)]

I've pushed an updated patch to working => collab/berick/param-log-warning-cleanup.

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/collab/berick/param-log-warning-cleanup

In addition to basing it on current code, it ensures that the warning in question will not occur regardless of the position of any null-valued params.

[Dan Scott (denials)]

Rebased this against current master and signed off at working/user/dbs/param-log-warning-cleanup

[Galen Charlton (gmc)]

I've tested and signed off as well, and pushed it to master and rel_2_1.