tests depend on precise values factory returns

[Michael Hudson-Doyle]

 I changed the factory to return different values from getUniqueInteger (from where all the uniquification comes in the factory) and the following tests failed:

lp.codehosting.scanner.tests.test_email.TestBzrSyncEmail.test_import_uncommit (code)
lp.soyuz.tests.test_archive.TestSeriesWithSources.test_series_with_sources_ordered_by_version (soyuz)
archive-deletion_txt (soyuz)
branch-karma_txt (code)
person-admin-views_txt (registry)
xx-branch-index_txt (code)
xx-distribution-packages_txt (registry)

These tests should all be fixed.

[Tim Penhey (thumper)]

lp.codehosting.scanner.tests.test_email.TestBzrSyncEmail.test_import_uncommit passes when I change the default start value.

The code looks fine. Do you have the original failure email?

[Michael Hudson-Doyle (mwhudson)]

Ah, looking at the error I see that what happened was that the name of the branch was longer, and so the subject header wrapped:

AssertionError: not equal:
a = u'[Branch ~person-name1119/product-name1114/branch1121] 1 revision removed'
b = '[Branch ~person-name1119/product-name1114/branch1121] 1 revision\n\tremoved'

I guess this is a fragility in the test, but not a very serious one.

[Ursula Junque (ursinha)]

Fixed in stable r10860 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10860>

[Ursula Junque (ursinha)]

Fixed in stable r10875 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10875>