Launchpad itself

Should forbid copies of expired sources

Bug #571104 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Steve Kowalik
Launchpad itself 10.04

Bug Description

CopyChecker.checkCopy() only checks for expired binaries. Now that we expire sources too, sourceful copies need to sometimes be denied too.

Related branches

lp:~stevenk/launchpad/fixes-bug-571104
Björn Tillenius (community): Approve (release-critical)
Michael Nelson (community): Approve (code)
Diff: 52 lines (+31/-0)
2 files modified
lib/lp/soyuz/scripts/packagecopier.py (+6/-0)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+25/-0)
Julian Edwards (julian-edwards)
Changed in soyuz:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Steve Kowalik (stevenk)
tags: added: soyuz-core
Revision history for this message
Julian Edwards (julian-edwards) wrote :

This is an r-c candidate, if Bjorn agrees.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10827 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10827>

Changed in soyuz:
milestone: none → 10.04
status: Triaged → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Steve Kowalik (stevenk) wrote :

I have sucessfully QA'd this branch on dogfood. Hacking an existing upload in a test PPA of mine, I set the orig tarball expires time and attempted to copy the source to a fresh PPA, generating the following error:

The following source cannot be copied:
* nothing 2.4-3.2 in karmic (source contains expired files)

tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.