PrettyOverlay has width fixed in CSS

Bug #570354 reported by Sidnei da Silva
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
LAZR Javascript Library
Fix Released
Medium
Paul Hummer

Bug Description

I wanted to host a wider widget inside a PrettyOverlay, by setting the widget size to a larger number. However the CSS on the #yui3-pretty-overlay-modal prevents it.

Ideally, it should be possible to create an overlay that takes 80% of the page by doing this:

    var overlay = new Y.lazr.PrettyOverlay({
            width: "80%")

Overriding the width to 'auto' makes it work:

#yui3-pretty-overlay-modal {
    width: auto !important;
}

Related branches

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

There are several other changes that need to be made:

1. .yui-pretty-overlay would also need the width set to auto.
2. The padding would need to be increased, or javascript would need to be added to prevent the overlay from looking ridiculously narrow for narrow content.
3. Resizing the window can cause strange resizing of the overlay if the width is set to auto.
4. #yui-pretty-overlay-modal should become a css class instead of an ID selector.

Revision history for this message
Paul Hummer (rockstar) wrote :

Edwin, can you verify that this bug still exists in lazr-js trunk? I suspect it doesn't, since we're not using a table anymore.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

Paul, this is still a problem in lazr-js trunk? Though the widget no longer uses a table, the yui-pretty-overlay css class sets the width to 402px, so it cannot grow with its content.

Also, since the overlay sets the z-index, WebKit browsers do not propagate click events correctly when the visibility style is set to hidden unless the z-index is also overridden to be -1. An example of this is the https://staging.launchpad.net/launchpad/+configure-bugtracker page. If you show the formoverlay by clicking on "Register an external bugtracker", dismiss the formoverlay by clicking outside of it, and then try to click on "Register an external bugtracker" again, it won't work.

Revision history for this message
Edwin Grubbs (edwin-grubbs) wrote :

ugh, that wasn't supposed to be a question. This definitely is still a problem in lazr-js trunk.

Paul Hummer (rockstar)
Changed in lazr-js:
assignee: Paul Hummer (rockstar) → nobody
status: New → Triaged
Paul Hummer (rockstar)
Changed in lazr-js:
assignee: nobody → Paul Hummer (rockstar)
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in lazr-js:
status: In Progress → Fix Committed
Paul Hummer (rockstar)
Changed in lazr-js:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.