[account_followup]incomplete information and parsing check

[Ruud Riem-Vis]

The followup text is not imported from the followup definition.

First you define a followup setting in "Financial Management->Configuration->Follow-Ups" where you add at least one Follow-up line. As an example put the text that you want to be printed in the follow up.

Then print the follow ups from the "Financial Management->Periodical Processing->Send Followups".

In the generated pdf, you will amongst others get the following :

1) The ZIP code and the city name are on two different lines. This should be on the same line (to be corrected in "account_followup/report/rappel.rml"
2) The paragraph styles on the address part are "terp_default_9" instead of "terp_default_address"
3) The line with the customer reference (line 119) should be remove from "account_followup/report/rappel.rml"
4) The maturity date is not filled in. This is a crucial information on a reminder.
5) If the partner language is french, there is a colon printed after the total ammount on a new line. The translation of the "Balance:" term is "Sole dû :" with a space before the colon. The colon is place on a new line. If you remove the white space in the translation and put "Solde dû:" the colon is on the same line. However, in french, there should be a white space before the colon.
6) If you put a blank line in the message string of the followup line, this blank line is not preserved. This is annoying as it is useful to be able to do some formatting on the text to be printed on the followup document.

What I further noticed is that if you make an error in the text of the followup line then the pdf printing fails completely without giving you a notice. For example if you try to use the term "%(partner_title)s" in the text to refere to the title of the partner, then you get a strange error in the output.

Thanks.

[JMA(Open ERP) (jma-openerp)]

Hello Ruud Riem-Vis,

I have made the appropriate changes as suggested by you.

Regarding,
4th point:
*Well the 'Maturity Date' column in the report is blank as when you create an invoice , in the 'Invoice form-view' you have a page 'Other Info' which has a field "Due Date" that has been left blank. You need to select the "Due Date" and then you will be able to see it in the report under 'Maturity Date' column.

6th point:
*If you have a message to be displayed in the 'followup line' then it will be printed in the report. However keeping that field empty will print the report normally as if there is no message to be displayed.

Please apply the patch and notify us.
Thank you.

[Ruud Riem-Vis (ruud-riem-vis)]

On 27.05.2010 12:08, JMA(Open ERP) wrote:
> Hello Ruud Riem-Vis,
>
> I have made the appropriate changes as suggested by you.
>
> Regarding,
> 4th point:
> *Well the 'Maturity Date' column in the report is blank as when you create an invoice , in the 'Invoice form-view' you have a page 'Other Info' which has a field "Due Date" that has been left blank. You need to select the "Due Date" and then you will be able to see it in the report under 'Maturity Date' column.
>
> 6th point:
> *If you have a message to be displayed in the 'followup line' then it will be printed in the report. However keeping that field empty will print the report normally as if there is no message to be displayed.
>
> Please apply the patch and notify us.
> Thank you.
>
> ** Attachment added: "changes"
> http://launchpadlibrarian.net/49196966/changes
>
>
Hi JMA,

Thanks for the update, I'll check tomorrow.
However :
4th point : the maturity date was defined (30 days payment) but not
shown in the report
6th point : I did not mean an empty followup line but a followup line
with a blank line for formatting purposes, e.g.:
"Dear customer,

On the account statement of ......

Yours sincerely.
"
Then the two blank lines will be eliminated in the report. That's what I
meant with point 6.

Best Regards,

Ruud

[Ruud Riem-Vis (ruud-riem-vis)]

Hello jma,

I've seen that under point 5, you've changed "Solde dû :" into "Solde
dû:". This is not correct. In french, there should be a space before the
colon so the original translation should be preserved.
The error I explained is that with the correct spelling including the
white space before the colon, the colon gets printed on the next line
(line wrap). This is probably caused by a lack of space and should be
solved in the rml template I suppose.

Regards,

Ruud

On 27.05.2010 12:08, JMA(Open ERP) wrote:
> Hello Ruud Riem-Vis,
>
> I have made the appropriate changes as suggested by you.
>
> Regarding,
> 4th point:
> *Well the 'Maturity Date' column in the report is blank as when you create an invoice , in the 'Invoice form-view' you have a page 'Other Info' which has a field "Due Date" that has been left blank. You need to select the "Due Date" and then you will be able to see it in the report under 'Maturity Date' column.
>
> 6th point:
> *If you have a message to be displayed in the 'followup line' then it will be printed in the report. However keeping that field empty will print the report normally as if there is no message to be displayed.
>
> Please apply the patch and notify us.
> Thank you.
>
> ** Attachment added: "changes"
> http://launchpadlibrarian.net/49196966/changes
>
>

[JMA(Open ERP) (jma-openerp)]

Hello Ruud,

Regarding the french translation changes please apply the patch notify us.

Thanks.

[Ruud Riem-Vis (ruud-riem-vis)]

On 28.05.2010 10:46, JMA(Open ERP) wrote:
> Hello Ruud,
>
> Regarding the french translation changes please apply the patch notify
> us.
>
> Thanks.
>
> ** Attachment added: "rml.changes"
> http://launchpadlibrarian.net/49252891/rml.changes
>
>
Hello jma,

I've applied the patches and the behavior is ok now. Just 3 minor points :
1) for a west-european settings, the time format is dd/mm/yyyy for the
followup date and the invoice date and yyyy-mm-dd for the maturity date.
This is not very clean.
2) the columns Due, Paid, and Maturity are not aligned correctly: the
lines for Sub-total: and Balance: are shifted a few pixels to the right.
3) the title attribute fields are missing in the rml.
I just remind also that empty newlines in the message printed above the
followup lines are filtered out.
Thanks,
Ruud

[JMA(Open ERP) (jma-openerp)]

Hello Ruud,

Please apply the patch and notify us.

Thanks.

[Ruud Riem-Vis (ruud-riem-vis)]

On 31.05.2010 11:54, JMA(Open ERP) wrote:
> Hello Ruud,
>
> Please apply the patch and notify us.
>
> Thanks.
>
> ** Attachment added: "rmlchanges"
> http://launchpadlibrarian.net/49428215/rmlchanges
>
>
Almost,

The latest patch solve the date formatting and aligns the columns but
lets the semicolon bug appaer again. I suggest to use the previous
Table2 line with the value 59.0 (instead of 55.0) in it and to change
the Table5 item 55.0 into 59.0 (so to shift the columns of the invoice
lines instead).

I just remind you the follow up data from the wizard which is not
propagated to the pdf date.

Ruud

[JMA(Open ERP) (jma-openerp)]

Hello Ruud,

I hope this resolves the alignment issue.

Thanks.

[Ruud Riem-Vis (ruud-riem-vis)]

On 01.06.2010 13:39, JMA(Open ERP) wrote:
> Hello Ruud,
>
> I hope this resolves the alignment issue.
>
> Thanks.
>
> ** Attachment added: "changes"
> http://launchpadlibrarian.net/49495228/changes
>
>
Hi Jay,
I just discovered a very small issue: the partner title is missing in
front of the partner name in the report partner address part.
This allows you to have the "M.", "Company", etc. titles in front of the
partner name.
The rest is fine now.
Regards,
Ruud

[JMA(Open ERP) (jma-openerp)]

Hi Ruud,

Things have finely been implemented in the newer trunk version.
Thank you.