TranslationTemplatesBuildJob fails during cleanup

[Jeroen T. Vermeulen]

Our build-farm jobs currently break in Q/A on dogfood, with this silly error:

    http://paste.ubuntu.com/421149/

This happens when things are almost done, while the slave is trying to report success to the master. On the master side, we then hit bug 496574.

[Jeroen T. Vermeulen (jtv)]

Here's the traceback:

Starting scanning cycle.
Did not find templates tarball in slave output.
Build produced no tarball.
Scanning failed with: 'NoneType' object has no attribute 'remove'

Traceback (most recent call last):
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/Twisted-10.0.0-py2.5-linux-i686.egg/twisted/internet/base.py", line 1170, in run
    self.mainLoop()
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/Twisted-10.0.0-py2.5-linux-i686.egg/twisted/internet/base.py", line 1179, in mainLoop
    self.runUntilCurrent()
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/Twisted-10.0.0-py2.5-linux-i686.egg/twisted/internet/base.py", line 778, in runUntilCurrent
    call.func(*call.args, **call.kw)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/manager.py", line 250, in startService
    d = defer.maybeDeferred(self.scan)
--- <exception caught here> ---
  File "/srv/launchpad.net/codelines/lp-sourcedeps/eggs/Twisted-10.0.0-py2.5-linux-i686.egg/twisted/internet/defer.py", line 117, in maybeDeferred
    result = f(*args, **kw)
  File "/srv/launchpad.net/codelines/trunk/lib/canonical/librarian/db.py", line 38, in retry_transaction_decorator
    return func(*args, **kwargs)
  File "/srv/launchpad.net/codelines/trunk/lib/canonical/database/sqlbase.py", line 736, in reset_store_decorator
    return func(*args, **kwargs)
  File "/srv/launchpad.net/codelines/trunk/lib/canonical/librarian/db.py", line 74, in write_transaction_decorator
    ret = func(*args, **kwargs)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/manager.py", line 343, in scan
    builder_set.pollBuilders(self.logger, transaction)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/model/builder.py", line 737, in pollBuilders
    self.scanActiveBuilders(logger, txn)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/model/builder.py", line 760, in scanActiveBuilders
    job.builder.updateBuild(job)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/model/builder.py", line 464, in updateBuild
    self.current_build_behavior.updateBuild(queueItem)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/model/buildfarmjobbehavior.py", line 115, in updateBuild
    method(queueItem, slave_status, logtail, logger)
  File "/srv/launchpad.net/codelines/trunk/lib/lp/translations/model/translationtemplatesbuildbehavior.py", line 121, in updateBuild_WAITING
    queue_item.destroySelf()
  File "/srv/launchpad.net/codelines/trunk/lib/lp/buildmaster/model/buildqueue.py", line 133, in destroySelf
    Store.of(specific_job).remove(specific_job)
exceptions.AttributeError: 'NoneType' object has no attribute 'remove'

[Ursula Junque (ursinha)]

Fixed in stable r10811 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10811>