Commandline --set-rating=N fails to update rating
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Exaile |
Invalid
|
Medium
|
Unassigned |
Bug Description
The commandline option --set-rating isn't updating the rating of the current track. Even with --debug or --eventdebug, no error is produced either.
I've tracked the bug down to two errors in xl/xldbus.py and compiled this diff to illustrate:
@@ -109,8 +109,8 @@
for command in modify_commands:
value = getattr(options, command)
- if value:
- iface.SetTrackA
+ if value:
+ iface.SetTrackA
comm = True
volume_
@@ -228,7 +228,7 @@
Sets rating of a track
"""
try:
- set_attr = getattr(
+ set_attr = getattr(
except AttributeError:
pass
The first problem is that if command == "SetRating", then command[4:].lower() == "ating". This should obviously be "rating". ;)
The second problem is that class Track has no attribute called "rating". The setter is called "set_rating". Hence the need to prefix "set_".
I'm kind of new to this open source way of working, so I have no idea yet how to submit these changes properly. I hope posting it here suffices for now.
Yours,
Jasper
Changed in exaile: | |
importance: | Undecided → Medium |
milestone: | none → 0.3.1.2 |
status: | New → Confirmed |
I should add that this bug applies to version 0.3.1b.