Create a BugWatchUpdater class that handles one BugWatch at a time
Bug #567793 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Graham Binns | ||
Bug Description
At the moment, the BugWatchUpdater class, which is pretty much all of the checkwatches code, is big, monolithic and very tangled up. We need to refactor this, and the first step is to move the BugWatch-handling code out into a separate class (which we're going to call BugWatchUpdater; we'll rename the parent class).
BugWatchUpdater should do all of the one-watch-specific work that's currently done in the existing BugWatchUpdater's updateBugWatches() method.
Related branches
lp:~gmb/launchpad/cw-refactor-add-bwu-bug-567793
- Gavin Panella (community): Approve
-
Diff: 1044 lines (+407/-294)8 files modifiedlib/lp/bugs/doc/externalbugtracker-comment-imports.txt (+24/-12)
lib/lp/bugs/doc/externalbugtracker-comment-pushing.txt (+26/-19)
lib/lp/bugs/doc/externalbugtracker-linking-back.txt (+22/-12)
lib/lp/bugs/scripts/checkwatches/base.py (+7/-1)
lib/lp/bugs/scripts/checkwatches/bugwatchupdater.py (+284/-0)
lib/lp/bugs/scripts/checkwatches/core.py (+14/-243)
lib/lp/bugs/scripts/checkwatches/tests/test_base.py (+21/-7)
utilities/less-oops.sh (+9/-0)
| tags: | added: mad-checkwatches-refactoring |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in malone: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-untestable removed: qa-needstesting |
| Changed in malone: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10797 <http://