Have a deterministic way to check OOPS generation in tests.
Bug #567689 reported by
Karl Fogel
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Tim Penhey | ||
Bug Description
We have no way to reliably test OOPS generation. For example, see the race condition recently documented in bug #567257. While there is a mostly-okay fix for that particular bug, we'd be much better off with a generalized solution that is not vulnerable to race conditions at all. See that bug, and lib/lp/
Related branches
lp:~thumper/launchpad/more-careful-network-service-usage
- Michael Hudson-Doyle: Approve
- Björn Tillenius (community): Approve
-
Diff: 465 lines (+224/-17)10 files modifiedlib/canonical/launchpad/webapp/errorlog.py (+9/-1)
lib/canonical/launchpad/webapp/interfaces.py (+5/-0)
lib/lp/code/model/branchmergeproposaljob.py (+9/-0)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+98/-1)
lib/lp/code/model/tests/test_diff.py (+2/-4)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+4/-2)
lib/lp/services/job/runner.py (+22/-7)
lib/lp/services/job/tests/test_runner.py (+63/-0)
lib/lp/testing/__init__.py (+11/-1)
lib/lp/testing/tests/test_fixture.py (+1/-1)
| description: | updated |
| summary: |
- Have a guaranteed way to check OOPS generation in tests. + Have a deterministic way to check OOPS generation in tests. |
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| milestone: | none → 10.04 |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in db-stable r9327 <http://