pbxt doesn't build under gcc on Solaris

[Lee Bieber]

See the complete log at - http://hudson.drizzle.org/view/Drizzle-staging/job/drizzle-staging-norbye.org-gcc/154/console

libtool: compile: /opt/gcc/bin/g++ -DHAVE_CONFIG_H -I. -I. -isystem ./gnulib -isystem ./gnulib -ggdb3 -I/opt/boost/cc/include -I/home/hudson/build/drizzle/include -isystem /opt/google-gcc/include -I/home/hudson/build/libdrizzle/include -D_REENTRANT -pthreads -pipe -std=gnu++0x -O0 -DDEBUG -Werror -pedantic -Wall -Wundef -Wshadow -fdiagnostics-show-option -Wformat -fno-strict-aliasing -Wno-strict-aliasing -Wextra -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long -Wmissing-declarations -Wno-redundant-decls -DDRIZZLED -Wno-overloaded-virtual -Wno-sign-compare -Wno-unused-function -m64 -MT plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo -MD -MP -MF plugin/pbxt/src/.deps/plugin_pbxt_libpbxt_la-cache_xt.Tpo -c plugin/pbxt/src/cache_xt.cc -fPIC -DPIC -o plugin/pbxt/src/.libs/plugin_pbxt_libpbxt_la-cache_xt.o
gmake[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo] Error 1
gmake[2]: *** Waiting for unfinished jobs....
In file included from plugin/pbxt/src/locklist_xt.h:40,
                 from plugin/pbxt/src/pthread_xt.h:36,
                 from plugin/pbxt/src/cache_xt.cc:37:
plugin/pbxt/src/xt_defs.h:592:5: error: "BYTE_ORDER" is not defined
plugin/pbxt/src/xt_defs.h:592:19: error: "BIG_ENDIAN" is not defined

[Lee Bieber (kalebral-deactivatedaccount)]

Also failing at http://hudson.drizzle.org/view/Drizzle-trunk/job/drizzle-trunk-bitters-gcc/155/console

[Monty Taylor (mordred)]

On 04/20/2010 01:54 PM, Lee Bieber wrote:
> Public bug reported:
>
> See the complete log at - http://hudson.drizzle.org/view/Drizzle-
> staging/job/drizzle-staging-norbye.org-gcc/154/console
>
>
> libtool: compile: /opt/gcc/bin/g++ -DHAVE_CONFIG_H -I. -I. -isystem ./gnulib -isystem ./gnulib -ggdb3 -I/opt/boost/cc/include -I/home/hudson/build/drizzle/include -isystem /opt/google-gcc/include -I/home/hudson/build/libdrizzle/include -D_REENTRANT -pthreads -pipe -std=gnu++0x -O0 -DDEBUG -Werror -pedantic -Wall -Wundef -Wshadow -fdiagnostics-show-option -Wformat -fno-strict-aliasing -Wno-strict-aliasing -Wextra -Woverloaded-virtual -Wnon-virtual-dtor -Wctor-dtor-privacy -Wno-long-long -Wmissing-declarations -Wno-redundant-decls -DDRIZZLED -Wno-overloaded-virtual -Wno-sign-compare -Wno-unused-function -m64 -MT plugin/pbxt/src/plugin_pbxt_libpbxt_la-cache_xt.lo -MD -MP -MF plugin/pbxt/src/.deps/plugin_pbxt_libpbxt_la-cache_xt.Tpo -c plugin/pbxt/src/cache_xt.cc -fPIC -DPIC -o plugin/pbxt/src/.libs/plugin_pbxt_libpbxt_la-cache_xt.o
> gmake[2]: *** [plugin/pbxt/src/plugin_pbxt_libpbxt_la-bsearch_xt.lo] Error 1
> gmake[2]: *** Waiting for unfinished jobs....
> In file included from plugin/pbxt/src/locklist_xt.h:40,
> from plugin/pbxt/src/pthread_xt.h:36,
> from plugin/pbxt/src/cache_xt.cc:37:
> plugin/pbxt/src/xt_defs.h:592:5: error: "BYTE_ORDER" is not defined
> plugin/pbxt/src/xt_defs.h:592:19: error: "BIG_ENDIAN" is not defined

If it's helpful - drizzle's build system defines WORDS_BIGENDIAN when on
a big endian platform. (This is a standard autoconf define) So something
like this:

=== modified file 'plugin/pbxt/src/xt_defs.h'
--- plugin/pbxt/src/xt_defs.h 2010-04-16 05:36:53 +0000
+++ plugin/pbxt/src/xt_defs.h 2010-04-20 21:43:19 +0000
@@ -589,7 +589,7 @@
   * the value cannot be assumed.
   *
   */
-#if BYTE_ORDER == BIG_ENDIAN
+#if defined(WORDS_BIGENDIAN)
  /* The native order of the machine is big endian. Since the native disk
   * disk order of XT is little endian, all data to and from disk
   * must be swapped.

Should do the trick.

> ** Affects: drizzle
> Importance: High
> Assignee: Paul McCullagh (paul-mccullagh)
> Status: Confirmed
>
> ** Affects: drizzle/cherry
> Importance: High
> Assignee: Paul McCullagh (paul-mccullagh)
> Status: Confirmed
>
> ** Changed in: drizzle
> Status: New => Confirmed
>
> ** Changed in: drizzle
> Milestone: None => 2010-04-26
>
> ** Changed in: drizzle
> Importance: Undecided => High
>
> ** Changed in: drizzle
> Assignee: (unassigned) => Paul McCullagh (paul-mccullagh)
>
> ** Also affects: drizzle/cherry
> Importance: High
> Assignee: Paul McCullagh (paul-mccullagh)
> Status: Confirmed
>

[Lee Bieber (kalebral-deactivatedaccount)]

Still seeing this build failure as of build 1510. See current log at http://hudson.drizzle.org/job/drizzle-staging-norbye.org-gcc/170/consoleFull

[Paul McCullagh (paul-mccullagh)]

Hi Lee,

How do I start a build of a specific tree on: http://hudson.drizzle.org/job/drizzle-staging-norbye.org-gcc

I would like to test any bug fixes that I try. I have prepared a tree for this purpose: lp:~paul-mccullagh/drizzle/compile-errors

Thanks!

[Jay Pipes (jaypipes)]

Hi Paul!

I don't see any param builder for Solaris/GCC. Monty, do you think we can add one?

-jay

[Monty Taylor (mordred)]

Added: http://hudson.drizzle.org/view/Drizzle-param/job/drizzle-param-solaris-gcc/

[Monty Taylor (mordred)]

Also, I just started a build of your tree.