Add possibility for another graphic when a builder enters a constructionsite

[SirVer]

Currently, one can't see if a builder is inside a constructionsite or not. This suggests adding a new animation that is played as soon as a builder enters a constructionsite.

[SirVer (sirver)]

This is implemented in r5241 together with place holder graphics. Chuck, could you please add proper graphics like the ones you proposed earlier.

[Chuck Wilder (chuckw20)]

I made an animation including my earlier construction site graphic and included the builder model in it for the constructionsite idle_with_worker and it runs fine. However it continues to run when the builder receives wares and starts to work. Net result is two animated workers in the construction site, one overlaying the other.

What I think we need, imho, is to:
1) keep the idle_with_worker construction site graphic static to maintain the change from "marker stone" to "site in progress" and
2) introduce a new idle_waiting_for_wares animation for the worker. Alternatively, use the current worker idle cycle (that is currently being used as a work cycle) as a true idle cycle and introduce a true work cycle.

That way, control of the worker images is maintained within the worker logic and not the "building" logic and the problem of simultaneous multiple worker images is resolved.

[SirVer (sirver)]

Sounds good to me, so I suggest doing the following:

1) rename idle_with_worker to in_progress or started. Which one do you like best?
2) add a working cycle to the builder and use the idle cycle as waiting for wares

I can do the coding stuff, but we should do those changes in a separate branch because we might take a while and in between the game looks funny. I will do the changes and write here which branch i pushed the changes.

Could you provide me with your original constructionsite proposal graphics? the current placeholder is quite irritating while playing and should be replaced asap. I should not have pushed these changes to trunk but into another branch.

[Chuck Wilder (chuckw20)]

On Mon, Apr 19, 2010 at 6:29 PM, SirVer <email address hidden> wrote:

> Sounds good to me, so I suggest doing the following:
>
> 1) rename idle_with_worker to in_progress or started. Which one do you like
> best?
>
I prefer started. It's short and to the point. :)

2) add a working cycle to the builder and use the idle cycle as waiting for
> wares
>
> I can do the coding stuff, but we should do those changes in a separate
> branch because we might take a while and in between the game looks
> funny. I will do the changes and write here which branch i pushed the
> changes.
>
Sounds good.

>
> Could you provide me with your original constructionsite proposal
> graphics?

It has been committed.

> I should not have pushed these changes to trunk
> but into another branch.
>
New graphics ARE exciting, aren't they? ;D

btw - I may have jumped the gun, too. I submitted a "wish list" report for
the extra builder work phase. See bug report # 566932 :s

[SirVer (sirver)]

Okay, the remainings of this are in bug 566932 so this is fix committed then.

[SirVer (sirver)]

Released in build16-rc1