/etc/cron.daily/apt assumes that CacheArchive inside CacheDir

[Alexander Pyhalov]

Binary package hint: apt

cron apt script assumes that CacheArchive directory is inside CacheDir. However, apt allows configuration when CacheArchive is outside CacheDir (for example, I use it because of space shortage in /var).
Some changes to /etc/cron.daily/apt like this would be useful...

--- /etc/cron.daily/apt 2010-04-17 11:42:26.000000000 +0400
+++ tmp/apt 2010-04-17 11:45:38.000000000 +0400
@@ -181,7 +181,11 @@
  exit
     fi

- Cache="${Dir%/}/${CacheDir%/}/${CacheArchive%/}/"
+ if [ "x$CacheArchive" != "x${CacheArchive#/}" ]; then
+ Cache="${CacheArchive%/}/";
+ else
+ Cache="${Dir%/}/${CacheDir%/}/${CacheArchive%/}/";
+ fi

     # check age
     if [ ! $MaxAge -eq 0 ] && [ ! $MinAge -eq 0 ]; then
@@ -279,7 +283,13 @@
  return
     fi

- Cache="${Dir}/${CacheDir}/${CacheArchive}/"
+
+ if [ "x$CacheArchive" != "x${CacheArchive#/}" ]; then
+ Cache="${CacheArchive%/}/";
+ else
+ Cache="${Dir%/}/${CacheDir%/}/${CacheArchive%/}/";
+ fi
+
     Back="${Dir}/${CacheDir}/${CacheBackup}/"
     BackX="${Back}${CacheArchive}/"
     for x in $(seq 0 1 $((${BackupLevel}-1))); do

[Torsten Spindler (tspindler)]

The code for the cron job has changed since the bug was reported:

    Cache="/var/cache/apt/archives/"
    eval $(apt-config shell Cache Dir::Cache::archives/d)

Does this allow for the intended behaviour of having a CacheArchive outside of CacheDir?

[Alexander Pyhalov (alp-rsu)]

Thanks, this fix works (however, it was not integrated in Ubuntu 10.04, which I use).

[Torsten Spindler (tspindler)]

Does the cron job from newer apt work on Ubuntu 10.04 LTS? Not sure if it's a SRU candidate as the problem doesn't seem to be that critical to me.

[Alexander Pyhalov (alp-rsu)]

Yes, it works.

[Torsten Spindler (tspindler)]

Ok, I will close this bug as won't fix then, as I don't think the risk of a regression in the apt cron job is at the same level as the benefit of the fix.