active ftp (aftp://) not properly supported
Bug #56472 reported by
John A Meinel
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Unassigned |
Bug Description
It seems that internally active ftp degrades to passive ftp.
Probably the first Transport object is properly active, but after 'clone()' it switches to passive FTP. Because it has stripped off the 'a' portion of 'aftp://' in the url.
A possible fix is to change FTPTransport.
proto = 'ftp'
if self.is_active:
proto = 'aftp'
return urlparse.
I will also attach a proposed fix by ghozzy_
To post a comment you must log in.
Fix proposed by ghozzy_.
Also needed would be a test case. It could either test that:
t = get_transport( 'aftp:/ /host/path' ) (t.is_active) (parent. is_active)
self.failUnless
parent = t.clone('..')
self.failUnless
We also should probably assert that:
self.assertEqua l('aftp: //host/ path/', t.abspath(''))
To make sure abspath is returing the right string.