giving bzr two options results in one being uknown

[Wouter van Heyst]

/usr/bin/bzr --profile revno
no problem

/usr/bin/bzr --no-plugins revno
no problem

/usr/bin/bzr --profile --no-plugins revno
bzr: ERROR: unknown command '--no-plugins'

/usr/bin/bzr --no-plugins --profile revno
bzr: ERROR: unknown command '--profile'

/usr/bin/bzr is 0.6 as in Debian sid, the problem also exists in bzr.dev

testcase coming up

[Wouter van Heyst (larstiq)]

Not asserting anything, just asserting that the self.run_bzr passes

[Wouter van Heyst (larstiq)]

The problem can be 'fixed' by not removing entries from argv while we're looping over it.

=== modified file 'bzrlib/commands.py'
--- bzrlib/commands.py
+++ bzrlib/commands.py
@@ -479,7 +479,7 @@
     # to load plugins before doing other command parsing so that they
     # can override commands, but this needs to happen first.

- for a in argv:
+ for a in list(argv):
         if a == '--profile':
             opt_profile = True
         elif a == '--no-plugins':

[Martin Pool (mbp)]

Fix seems to be in main now - thanks Wouter.