ppa-reset ssh failures should be fatal, not just leave the builder idle for 3 months
Bug #563353 reported by
LaMont Jones
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Julian Edwards |
Bug Description
when known_hosts fails to have the host key for a ppa builder, and build-master resets the host, it currently goes "hrm, that failed, let's leave the builder idle so that the admin never looks at it, and see if maybe it magically starts working again later"
This behavior should change to "broken, admin attention required", say with something like "ppa-reset trigger failed" or such in the reason for disabling the buildd.
thanks,
lamont
Related branches
lp:~julian-edwards/launchpad/builder-reset-fail-bug-563353
Merged
into
lp:launchpad
- Jonathan Lange (community): Approve
-
Diff: 428 lines (+198/-36)3 files modifiedlib/lp/buildmaster/manager.py (+33/-17)
lib/lp/buildmaster/tests/test_manager.py (+96/-19)
lib/lp/services/twistedsupport/processmonitor.py (+69/-0)
tags: | added: buildd-manager |
Changed in soyuz: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in soyuz: | |
status: | Triaged → In Progress |
Changed in soyuz: | |
assignee: | nobody → Julian Edwards (julian-edwards) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in soyuz: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r10775 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 10775>