approving merge proposal by email can hit db permission error

[Michael Hudson-Doyle]

As seen in https://lp-oops.canonical.com/oops.py/?oopsid=1564CEMAIL22, the 'processmail' user needs select on the codeimport table.

This isn't biting us all the time because of the order in which things that grant you launchpad.Edit on the merge proposal are checked: it's the third line out of this condition that hits the problem:

        return (user.inTeam(self.obj.registrant) or
                user.inTeam(self.obj.source_branch.owner) or
                check_permission('launchpad.Edit', self.obj.target_branch) or
                user.inTeam(self.obj.target_branch.reviewer))

[John A Meinel (jameinel)]

What is this going to take to get fixed? My standard review model is to review via email, and when one of these email bounces, it doesn't even post the comment on the review. So I have to go track down what email I was reviewing (since the URL isn't included in the failure message), and then track down my original submission, and copy and paste it into the review dialog. (And then click 2-3 more times to get all the review statuses updated.)

It gets in my way about 1-2 times per day, and basically makes it so that reviewing is basically the last thing I want to be doing...

[Aaron Bentley (abentley)]

John, it has been fixed, but the fix cannot be deployed to edge. It must wait for our next full release. That will be on Tuesday.

[Tim Penhey (thumper)]

On Sat, 01 May 2010 06:29:55 you wrote:
> What is this going to take to get fixed? My standard review model is to
> review via email, and when one of these email bounces, it doesn't even
> post the comment on the review. So I have to go track down what email I
> was reviewing (since the URL isn't included in the failure message), and
> then track down my original submission, and copy and paste it into the
> review dialog. (And then click 2-3 more times to get all the review
> statuses updated.)
>
> It gets in my way about 1-2 times per day, and basically makes it so
> that reviewing is basically the last thing I want to be doing...

The fix has been landed, and will be rolled out on Tuesday.

Tim

[Ursula Junque (ursinha)]

Fixed in db-stable r9316 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/9316>