broken syncdaemon.conf; improve the error handling

[Jan Oetjen]

For reasons I don't know my syncdaemon.conf looks exactly like:

org/1999/02/22-rdf-syntax-ns#li> "iPod" .
<http://fakebase.f-spot.

which obviously is completly wrong. Unfortunately the Ubuntu One Client is missing some error checking when reading the file and crashes if I right click the icon. I simply fixed this by removing the config directory and letting the client generate a new one, but I think it would be a good idea to improve the error handling when the file is read in the client to prevent crashes.

Jan

P.S.: I attached the broken syncdaemon.conf

[Roberto Alsina (ralsina)]

I confirmed it on Maverick and Natty, version:

ii ubuntuone-client 1.5.3+r839~natty1

If I create a garbage syncdaemon.conf, it fails with this error:

Traceback (most recent call last):
  File "/usr/lib/ubuntuone-client/ubuntuone-syncdaemon", line 187, in <module>
    main(sys.argv)
  File "/usr/lib/ubuntuone-client/ubuntuone-syncdaemon", line 74, in main
    args=args, usage=usage)
  File "/usr/lib/pymodules/python2.7/ubuntuone/syncdaemon/config.py", line 375, in configglue
    cp.read(filenames)
  File "/usr/lib/python2.7/ConfigParser.py", line 297, in read
    self._read(fp, filename)
  File "/usr/lib/python2.7/ConfigParser.py", line 504, in _read
    raise MissingSectionHeaderError(fpname, lineno, line)
ConfigParser.MissingSectionHeaderError: File contains no section headers.
file: /home/ralsina/.config/ubuntuone/syncdaemon.conf, line: 1