bzr should not pass -oProtocol=2 to openssh

[Jason R. Coombs]

I was trying to use bzr 2.0.2 on Ubuntu Karmic Koala when I found I couldn't push to my repository on launchpad.

See https://answers.edge.launchpad.net/launchpad-code/+question/107036 for details.

Apparently, bzr recognizes 'id_dsa' as a valid private key name, but not 'identity'. OpenSSH recognizes identity; bzr probably should too.

[Robert Collins (lifeless)]

Lets finish this on that open question; if its a bug we'll convert it at
the point that becomes clear.

 status invalid

[Martin Pool (mbp)]

As discussed in https://answers.edge.launchpad.net/launchpad-code/+question/107036 we are forcing protocol 2, even though that seems to be the default in current ssh. I don't see why passing that parameter is useful.

[Martin Pool (mbp)]

Even in Dapper <http://manpages.ubuntu.com/manpages/dapper/en/man5/ssh_config.5.html> openssh tries 2 first.

[Andrew Bennetts (spiv)]

I'm not sure why it forces protocol 2 either. Maybe SSH 1 doesn't support the SFTP subsystem? Even so think leaving the choice of protocol version to /usr/bin/ssh is fine, so I agree: let's stop passing -oProtocol=2.

[Robert Collins (lifeless)]

On Mon, 2010-04-12 at 05:22 +0000, Andrew Bennetts wrote:
> I'm not sure why it forces protocol 2 either. Maybe SSH 1 doesn't
> support the SFTP subsystem? Even so think leaving the choice of
> protocol version to /usr/bin/ssh is fine, so I agree: let's stop passing
> -oProtocol=2.

JamesH wrote this code - James, do you remember why you forced protocol
for openssh in bzr?

-Rob