ROHC library mishandles non-IPv4/IPv6 packets

[Didier Barvaux]

When compressing non-IP packets or IP packets in which IP version is not 4 or 6, the ROHC compressor fails with the following messages:
  [ip.c:31 ip_create()] bad IP version (4)
  [ERROR] [rohc_comp.c:172 rohc_compress()] cannot create the outer IP header

ROHC library version: 1.3.0
Expected result: the packets should be compressed using the Uncompressed profile.
Reproductible: always, the attached traffic capture contains IP packets in which IP version is 5. It can be used to reproduce the problem.

[Didier Barvaux (didier-barvaux)]

Confirmed in branch 1.3.x.

[Didier Barvaux (didier-barvaux)]

Also affects branch 1.2.x.

[Didier Barvaux (didier-barvaux)]

Also affects trunk.

[Didier Barvaux (didier-barvaux)]

While parsing the IP headers, malfomed IP headers should not stop the compression process. The packet should be flagged as non-IP, then the Uncompressed compression profile should be selected.

[Didier Barvaux (didier-barvaux)]

Fixed in branch 1.2.x. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.2.x/revision/115.

[Didier Barvaux (didier-barvaux)]

Fixed in branch 1.3.x. See http://bazaar.launchpad.net/~didier-barvaux/rohc/1.3.x/revision/138. The correction is the same as branch 1.2.x.

[Didier Barvaux (didier-barvaux)]

Fixed in trunk. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/145. The correction is globally the same as branches 1.2.x and 1.3.x except that:
 - I added some debug traces in src/comp/rohc_comp.c,
 - I added some doxygen comments and assertions in code of ip.c to avoid mis-use of the functions
   related to IP packets,
 - I made the c_get_profile_from_packet() function static in src/comp/rohc_comp.c.

[Didier Barvaux (didier-barvaux)]

In all branches, the attached PCAP traffic capture was used to create a new non-regression tests. It is located in the sub-directory test/report/samples/ipvx/ as the PCAP contains IP packet whose version is not 4 nor 6.

[Didier Barvaux (didier-barvaux)]

Fix released in version 1.3.1.

[Didier Barvaux (didier-barvaux)]

Fix released in version 1.2.2.