Don't stop the upgrade to inform about service restarts

[Scott Kitterman]

Binary package hint: update-manager

The pam upgrade blocks the entire release upgrade process until it is acknowledged:

Preparing to replace libpam0g 1.1.0-2ubuntu1 (using .../libpam0g_1.1.1-2ubuntu1_i386.deb) ...
Unpacking replacement libpam0g ...
Setting up libpam0g (1.1.1-2ubuntu1) ...
Checking for services that may need to be restarted...Checking init scripts...

Restarting services possibly affected by the upgrade:
  saslauthd: stopping...starting...done.
  cron: stopping...starting...done.
  atd: stopping...starting...done.

Services restarted successfully.

While this is normally a good practice, when upgrading to a new release, it risks hanging the upgrade process and serves no purpose (there is no option other than go ahead and all services get restarted at some point during the upgrade process, so this isn't news). This should be notification should be disabled during upgrades to a new release.

[Steve Langasek (vorlon)]

libpam0g prompts for this on upgrade because it has no way of knowing whether all of those services are being upgraded at the same time. If they're not, the user may not be expecting the service interruption, so the behavior is to ask the user first before restarting services from other packages.

Note that the prompt is suppressed if running under update-manager and the user does not have any non-default services installed. In this case you have sasl2-bin installed, which is not a service installed on a default desktop.

[Scott Kitterman (kitterman)]

Right, but this was a server upgrade. Default desktop is rather irrelevant.

[Steve Langasek (vorlon)]

That's true, but OTOH it's that much more important on a server than on a desktop to not restart services when the admin isn't expecting it. I understand that in this case you *were* expecting it, but as this may even restart services whose packages are not being upgraded (because the package remains unchanged for 6 months?), I'm very hesitant to restart non-default services without an explicit warning to the admin.

If you can get agreement from the ubuntu-server community at large that it's ok to have unannounced service restarts in this case, then I'm willing to make the change.