cron.publish-ftpmaster untested
Bug #55798 reported by
Malcolm Cleaton
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
The cron.daily script mixes up essential functionality and production-specific hardcodedness, and does it all in shellscript. This makes it very difficult to test, and at the moment we have zero test coverage for cron.daily.
Related branches
lp:~jtv/launchpad/db-bug-55798
- Julian Edwards (community): Approve
-
Diff: 2029 lines (+1470/-84)24 files modifiedconfigs/development/launchpad-lazr.conf (+7/-0)
cronscripts/publish-ftpmaster.py (+17/-0)
cronscripts/publishing/cron.publish-ftpmaster (+50/-38)
cronscripts/publishing/distro-parts/ubuntu/finalize.d/10-germinate (+6/-0)
cronscripts/publishing/distro-parts/ubuntu/finalize.d/40-timestamp-trace-file (+9/-0)
cronscripts/publishing/distro-parts/ubuntu/finalize.d/90-trigger-mirrors (+14/-0)
cronscripts/publishing/distro-parts/ubuntu/finalize.d/README.txt (+22/-0)
cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/10-sign-releases (+17/-0)
cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/20-remove-uncompressed-listings (+11/-0)
cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/30-copy-indices (+8/-0)
cronscripts/publishing/distro-parts/ubuntu/publish-distro.d/README.txt (+22/-0)
lib/canonical/config/schema-lazr.conf (+15/-0)
lib/lp/archivepublisher/config.py (+6/-6)
lib/lp/archivepublisher/scripts/publish_ftpmaster.py (+429/-0)
lib/lp/archivepublisher/tests/test_publish_ftpmaster.py (+699/-0)
lib/lp/archivepublisher/tests/test_publisher.py (+1/-2)
lib/lp/services/tests/test_utils.py (+34/-5)
lib/lp/services/utils.py (+12/-0)
lib/lp/soyuz/enums.py (+12/-7)
lib/lp/soyuz/model/archive.py (+17/-16)
lib/lp/soyuz/scripts/processaccepted.py (+7/-1)
lib/lp/testing/__init__.py (+10/-8)
lib/lp/testing/factory.py (+22/-1)
lib/lp/testing/tests/test_factory.py (+23/-0)
- Launchpad code reviewers: Pending (code) requested
-
Diff: 6630 lines (+3344/-792)112 files modifiedconfigs/development/launchpad-lazr.conf (+0/-4)
configs/testrunner/launchpad-lazr.conf (+0/-3)
cronscripts/publish-ftpmaster.py (+17/-0)
cronscripts/publishing/cron.publish-ftpmaster (+52/-40)
cronscripts/publishing/distro-parts/production/ubuntu/finalize.d/10-germinate (+6/-0)
cronscripts/publishing/distro-parts/production/ubuntu/finalize.d/40-timestamp-trace-file (+5/-0)
cronscripts/publishing/distro-parts/production/ubuntu/finalize.d/90-trigger-mirrors (+14/-0)
cronscripts/publishing/distro-parts/production/ubuntu/finalize.d/README.txt (+13/-0)
cronscripts/publishing/distro-parts/production/ubuntu/publish-distro.d/10-sign-releases (+16/-0)
cronscripts/publishing/distro-parts/production/ubuntu/publish-distro.d/20-remove-uncompressed-listings (+11/-0)
cronscripts/publishing/distro-parts/production/ubuntu/publish-distro.d/30-copy-indices (+8/-0)
cronscripts/publishing/distro-parts/production/ubuntu/publish-distro.d/README.txt (+19/-0)
database/sampledata/current-dev.sql (+149/-113)
database/sampledata/current.sql (+144/-109)
database/schema/comments.sql (+3/-3)
database/schema/launchpad_session.sql (+25/-0)
database/schema/patch-2208-51-0.sql (+18/-0)
database/schema/patch-2208-52-0.sql (+14/-0)
database/schema/patch-2208-53-0.sql (+20/-0)
database/schema/patch-2208-54-0.sql (+6/-0)
database/schema/patch-2208-55-0.sql (+24/-0)
database/schema/patch-2208-56-0.sql (+33/-0)
database/schema/patch-2208-57-1.sql (+14/-0)
database/schema/security.cfg (+6/-0)
database/schema/security.py (+182/-99)
lib/canonical/config/schema-lazr.conf (+5/-8)
lib/canonical/launchpad/database/message.py (+2/-0)
lib/canonical/launchpad/interfaces/message.py (+2/-0)
lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+1/-1)
lib/canonical/launchpad/pagetests/webservice/xx-hide-comments.txt (+2/-2)
lib/canonical/launchpad/security.py (+23/-8)
lib/canonical/launchpad/zcml/message.zcml (+4/-3)
lib/lp/app/stories/launchpad-root/site-search.txt (+5/-3)
lib/lp/archivepublisher/config.py (+8/-7)
lib/lp/archivepublisher/deathrow.py (+2/-7)
lib/lp/archivepublisher/interfaces/publisherconfig.py (+58/-0)
lib/lp/archivepublisher/model/publisherconfig.py (+68/-0)
lib/lp/archivepublisher/publishing.py (+1/-6)
lib/lp/archivepublisher/tests/test_publisherconfig.py (+92/-0)
lib/lp/archivepublisher/zcml/configure.zcml (+25/-1)
lib/lp/bugs/browser/bugcomment.py (+1/-1)
lib/lp/bugs/configure.zcml (+5/-1)
lib/lp/bugs/doc/bugmessage-visibility.txt (+9/-8)
lib/lp/bugs/doc/bugnotification-sending.txt (+9/-3)
lib/lp/bugs/enum.py (+4/-4)
lib/lp/bugs/interfaces/bug.py (+1/-1)
lib/lp/bugs/interfaces/bugmessage.py (+0/-2)
lib/lp/bugs/mail/bugnotificationrecipients.py (+11/-0)
lib/lp/bugs/model/bug.py (+1/-1)
lib/lp/bugs/model/bugmessage.py (+0/-1)
lib/lp/bugs/model/bugnotification.py (+11/-0)
lib/lp/bugs/model/structuralsubscription.py (+4/-3)
lib/lp/bugs/security.py (+2/-7)
lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt (+1/-1)
lib/lp/bugs/tests/test_bug_messages_webservice.py (+1/-1)
lib/lp/code/model/tests/test_recipebuilder.py (+2/-2)
lib/lp/registry/adapters.py (+10/-0)
lib/lp/registry/browser/configure.zcml (+8/-8)
lib/lp/registry/browser/distribution.py (+75/-2)
lib/lp/registry/browser/distroseries.py (+70/-28)
lib/lp/registry/browser/tests/test_distribution_views.py (+167/-0)
lib/lp/registry/browser/tests/test_series_views.py (+127/-8)
lib/lp/registry/configure.zcml (+8/-1)
lib/lp/registry/doc/distroseries.txt (+8/-4)
lib/lp/registry/interfaces/distribution.py (+7/-2)
lib/lp/registry/interfaces/distroseries.py (+7/-2)
lib/lp/registry/interfaces/distroseriesdifference.py (+7/-3)
lib/lp/registry/model/distribution.py (+10/-5)
lib/lp/registry/model/distroseries.py (+8/-3)
lib/lp/registry/model/distroseriesdifference.py (+13/-7)
lib/lp/registry/stories/distribution/xx-distribution-launchpad-usage.txt (+24/-1)
lib/lp/registry/stories/distribution/xx-distribution-overview.txt (+3/-1)
lib/lp/registry/stories/distroseries/xx-distroseries-index.txt (+3/-1)
lib/lp/registry/stories/distroseries/xx-reassign-distroseries.txt (+0/-72)
lib/lp/registry/stories/webservice/xx-distribution.txt (+1/-0)
lib/lp/registry/stories/webservice/xx-distroseries.txt (+2/-1)
lib/lp/registry/templates/distribution-index.pt (+2/-2)
lib/lp/registry/templates/distroseries-index.pt (+2/-5)
lib/lp/registry/templates/distroseries-localdifferences.pt (+9/-0)
lib/lp/registry/templates/packagesearch-macros.pt (+3/-6)
lib/lp/registry/tests/test_distribution.py (+111/-3)
lib/lp/registry/tests/test_distributionsourcepackage.py (+2/-1)
lib/lp/registry/tests/test_distroseries.py (+9/-0)
lib/lp/registry/tests/test_pillarname_triggers.py (+10/-7)
lib/lp/scripts/garbo.py (+86/-8)
lib/lp/scripts/tests/test_garbo.py (+161/-4)
lib/lp/scripts/utilities/sanitizedb.py (+16/-3)
lib/lp/services/configure.zcml (+1/-0)
lib/lp/services/session/adapters.py (+40/-0)
lib/lp/services/session/configure.zcml (+12/-0)
lib/lp/services/session/interfaces.py (+15/-0)
lib/lp/services/session/model.py (+47/-0)
lib/lp/services/session/tests/test_session.py (+32/-0)
lib/lp/services/utils.py (+12/-0)
lib/lp/soyuz/doc/archive-dependencies.txt (+73/-73)
lib/lp/soyuz/doc/archive.txt (+8/-5)
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+30/-30)
lib/lp/soyuz/doc/publishing.txt (+5/-2)
lib/lp/soyuz/interfaces/distroarchseries.py (+3/-1)
lib/lp/soyuz/model/archive.py (+5/-4)
lib/lp/soyuz/scripts/processaccepted.py (+7/-1)
lib/lp/soyuz/scripts/publish_ftpmaster.py (+374/-0)
lib/lp/soyuz/scripts/tests/test_publish_ftpmaster.py (+419/-0)
lib/lp/soyuz/scripts/tests/test_publishdistro.py (+8/-3)
lib/lp/soyuz/stories/distroseries/add-architecture.txt (+10/-0)
lib/lp/soyuz/tests/test_packageupload.py (+16/-8)
lib/lp/testing/__init__.py (+10/-8)
lib/lp/testing/factory.py (+53/-6)
lib/lp/testing/tests/test_factory.py (+23/-0)
lib/lp/testing/tests/test_standard_test_template.py (+5/-4)
lib/lp/translations/browser/tests/test_sharing_information.py (+6/-4)
utilities/soyuz-sampledata-setup.py (+2/-2)
Revision history for this message
| Malcolm Cleaton (malcolmcleaton) wrote | #1 |
| Changed in soyuz: | |
| status: | Unconfirmed → Confirmed |
| Changed in soyuz: | |
| importance: | Undecided → High |
| status: | Confirmed → Triaged |
| tags: | added: feature |
| summary: |
- cron.daily untested + cron.publish-ftpmaster untested |
| tags: | added: derivation |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #2 |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| milestone: | none → 11.04 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #4 |
| tags: |
added: qa-bad removed: qa-needstesting |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #5 |
| Changed in launchpad: | |
| milestone: | 11.04 → 11.05 |
| tags: | added: bad-commit-r10383 |
| tags: |
added: bad-commit-10383 removed: bad-commit-r10383 |
| tags: |
added: qa-ok removed: qa-bad |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We should rewrite cron.daily in python.