launchpad's auto-sync comment to bugzilla is linkified upstream

Bug #557032 reported by Micah Gersten
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Graham Binns

Bug Description

If you look at this bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=140751#c27

This text is pushed upstream:
Micah Gersten added the following comment to Launchpad bug #494067:

But the link is to a bug in the upstream tracker. I know that LP doesn't control the upstream tracker links, but wanted to file a bug to start a discussion on possible solutions. A bug might need to be filed on bugzilla's upstream tracker once the local options are exhausted.

Related branches

Revision history for this message
Graham Binns (gmb) wrote :

My first instinct would to be to remove that annoying hash to stop the links from being created. Sounds like a relatively easy win.

Changed in malone:
status: New → Triaged
importance: Undecided → Medium
tags: added: bugwatch trivial
Revision history for this message
Reed Loden (reed) wrote : Re: [Bug 557032] Re: launchpad's auto-sync comment to bugzilla is linkified upstream

On Wed, 07 Apr 2010 08:53:23 -0000
Graham Binns <email address hidden> wrote:

> My first instinct would to be to remove that annoying hash to stop the
> links from being created. Sounds like a relatively easy win.

Except that won't fix anything, as Bugzilla will linkify "bug xxxx"
comments with or without the hash. What about just dropping the "bug"
part completely and just have it say "Launchpad #xxxxx"?

~reed

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 557032] Re: launchpad's auto-sync comment to bugzilla is linkified upstream

On 7 April 2010 10:25, Reed Loden <email address hidden> wrote:
> On Wed, 07 Apr 2010 08:53:23 -0000
> Graham Binns <email address hidden> wrote:
>
>> My first instinct would to be to remove that annoying hash to stop the
>> links from being created. Sounds like a relatively easy win.
>
> Except that won't fix anything, as Bugzilla will linkify "bug xxxx"
> comments with or without the hash. What about just dropping the "bug"
> part completely and just have it say "Launchpad #xxxxx"?

Ah, right. Trouble is that Tracs will still linkify #xxxx as link to a
local ticket, so that won't help either. Maybe the simplest thing to
do would be to include the bug URL in the "Foo added the following
comment..." text, so rather than saying "... to Launchpad bug #..." it
would say "to https://launchpad.net/bugs/..."

However, that doesn't seem a very nice way to do it either (and the
URL's already in the comment footer, which seems like a nicer place
for it to go.

I'm open to suggestions about how the pushed comments should best be
formatted to avoid this problem, but maybe it will need to be
something that needs to be fixed in the plugins (trac-launchpad and
bugzilla-launchpad) and in Bugzilla 3.4, too.

Revision history for this message
Graham Binns (gmb) wrote :

That's just brilliant. My link to launchpad.net/bugs/... above resulted in a new bugwatch. Brilliant.

Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

Maybe you should add links at the bottom of the comment, like:

Bug 12345456342345234534345: https://launchpad.net/boogs/2345456342345234534345

Revision history for this message
Max Kanat-Alexander (mkanat) wrote :

FWIW, I think that Bugzilla users are used to the occasional "bug 123123123123123" not linking to the right place, if the text looks something like "GNOME Bug 123" or something like that.

Revision history for this message
Bryce Harrington (bryce) wrote :

Looking at https://bugzilla.mozilla.org/show_bug.cgi?id=140751#c27 it looks like each comment already has a link back to the LP bug report, so all we have to do is change our comment to not trigger the automatic linker.

This patch should suffice.

Bryce Harrington (bryce)
tags: added: better-forwarding
Graham Binns (gmb)
Changed in malone:
status: Triaged → In Progress
assignee: nobody → Graham Binns (gmb)
tags: added: bugjam2010
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit
tags: added: qa-needstesting
Changed in malone:
status: In Progress → Fix Committed
Graham Binns (gmb)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
milestone: none → 11.01
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.